chore(end-to-end): do not os.Exit and return an error instead (#2452)

- `RunGossamer`: do not `os.Exit` and return an error
- `InitializeAndStartNodes` return error and teardown nodes on error
- `InitializeAndStartNodesWebsocket` return error and teardown nodes on error
- Fix thread safety on nodes slice in `InitializeAndStartNodesWebsocket`

Author: qdm12

tests/utils/gossamer_utils.go

@@ -233,8 +233,7 @@ func startGossamer(t *testing.T, node *Node, websocket bool) error {
 func RunGossamer(t *testing.T, idx int, basepath, genesis, config string, websocket, babeLead bool) (*Node, error) {
 	node, err := InitGossamer(idx, basepath, genesis, config)
 	if err != nil {
-		Logger.Criticalf("could not initialise gossamer: %s", err)
-		os.Exit(1)
+		return nil, fmt.Errorf("could not initialise gossamer: %w", err)
 	}
 
 	if idx == 0 || babeLead {
@@ -243,8 +242,7 @@ func RunGossamer(t *testing.T, idx int, basepath, genesis, config string, websoc
 
 	err = startGossamer(t, node, websocket)
 	if err != nil {
-		Logger.Criticalf("could not start gossamer: %s", err)
-		os.Exit(1)
+		return nil, fmt.Errorf("could not start gossamer: %w", err)
 	}
 
 	return node, nil
@@ -314,61 +312,83 @@ func StartNodes(t *testing.T, nodes []*Node) error {
 }
 
 // InitializeAndStartNodes will spin up `num` gossamer nodes
-func InitializeAndStartNodes(t *testing.T, num int, genesis, config string) ([]*Node, error) {
-	var nodes []*Node
-
+func InitializeAndStartNodes(t *testing.T, num int, genesis, config string) (
+	nodes []*Node, err error) {
 	var wg sync.WaitGroup
-	var nodeMu sync.Mutex
+	var nodesMutex, errMutex sync.Mutex
 	wg.Add(num)
 
 	for i := 0; i < num; i++ {
 		go func(i int) {
+			defer wg.Done()
 			name := strconv.Itoa(i)
 			if i < len(KeyList) {
 				name = KeyList[i]
 			}
-			node, err := RunGossamer(t, i, TestDir(t, name), genesis, config, false, false)
-			if err != nil {
-				Logger.Errorf("failed to run Gossamer for node index %d", i)
+			node, runErr := RunGossamer(t, i, TestDir(t, name), genesis, config, false, false)
+			if runErr != nil {
+				errMutex.Lock()
+				if err == nil {
+					err = fmt.Errorf("failed to run Gossamer for node index %d: %w", i, runErr)
+				}
+				errMutex.Unlock()
+				return
 			}
 
-			nodeMu.Lock()
+			nodesMutex.Lock()
 			nodes = append(nodes, node)
-			nodeMu.Unlock()
-			wg.Done()
+			nodesMutex.Unlock()
 		}(i)
 	}
 
 	wg.Wait()
 
+	if err != nil {
+		_ = StopNodes(t, nodes)
+		return nil, err
+	}
+
 	return nodes, nil
 }
 
 // InitializeAndStartNodesWebsocket will spin up `num` gossamer nodes running with Websocket rpc enabled
-func InitializeAndStartNodesWebsocket(t *testing.T, num int, genesis, config string) ([]*Node, error) {
-	var nodes []*Node
-
+func InitializeAndStartNodesWebsocket(t *testing.T, num int, genesis, config string) (
+	nodes []*Node, err error) {
+	var nodesMutex, errMutex sync.Mutex
 	var wg sync.WaitGroup
+
 	wg.Add(num)
 
 	for i := 0; i < num; i++ {
 		go func(i int) {
+			defer wg.Done()
 			name := strconv.Itoa(i)
 			if i < len(KeyList) {
 				name = KeyList[i]
 			}
-			node, err := RunGossamer(t, i, TestDir(t, name), genesis, config, true, false)
-			if err != nil {
-				Logger.Errorf("failed to run Gossamer for node index %d", i)
+			node, runErr := RunGossamer(t, i, TestDir(t, name), genesis, config, true, false)
+			if runErr != nil {
+				errMutex.Lock()
+				if err == nil {
+					err = fmt.Errorf("failed to run Gossamer for node index %d: %w", i, runErr)
+				}
+				errMutex.Unlock()
+				return
 			}
 
+			nodesMutex.Lock()
 			nodes = append(nodes, node)
-			wg.Done()
+			nodesMutex.Unlock()
 		}(i)
 	}
 
 	wg.Wait()
 
+	if err != nil {
+		_ = StopNodes(t, nodes)
+		return nil, err
+	}
+
 	return nodes, nil
 }
 

tests/utils/request_utils.go

@@ -66,7 +66,7 @@ func PostRPCWithRetry(ctx context.Context, endpoint, method, params string,
 
 		postRPCCtx, postRPCCancel := context.WithTimeout(ctx, requestWait)
 
-		data, err := PostRPC(postRPCCtx, endpoint, method, params)
+		data, err = PostRPC(postRPCCtx, endpoint, method, params)
 
 		if err == nil {
 			postRPCCancel()