fix(lib/babe): check if authority index is in the authorities range (#2601)

EclesioMeloJunior · web-flow · commit 1072888bb936 · 2022-06-21T08:09:37.000-04:00
diff --git a/lib/babe/verify.go b/lib/babe/verify.go
@@ -390,7 +390,7 @@ func (b *verifier) verifyPreRuntimeDigest(digest *types.PreRuntimeDigest) (scale
 		authIdx = d.AuthorityIndex
 	}
 
-	if len(b.authorities) <= int(authIdx) {
+	if uint64(len(b.authorities)) <= uint64(authIdx) {
 		logger.Tracef("verifyPreRuntimeDigest invalid auth index %d, we have %d auths",
 			authIdx, len(b.authorities))
 		return nil, ErrInvalidBlockProducerIndex

Original file line number	Diff line number	Diff line change
`@@ -390,7 +390,7 @@ func (b verifier) verifyPreRuntimeDigest(digest types.PreRuntimeDigest) (scale`
`390`	`390`	`authIdx = d.AuthorityIndex`
`391`	`391`	`}`
`392`	`392`
`393`		`- if len(b.authorities) <= int(authIdx) {`
	`393`	`+ if uint64(len(b.authorities)) <= uint64(authIdx) {`
`394`	`394`	`logger.Tracef("verifyPreRuntimeDigest invalid auth index %d, we have %d auths",`
`395`	`395`	`authIdx, len(b.authorities))`
`396`	`396`	`return nil, ErrInvalidBlockProducerIndex`