Skip to content

Commit 1db5f56

Browse files
committed
add cache hit tracing log
1 parent 8a977e7 commit 1db5f56

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

ibis-server/app/routers/v2/connector.py

+8-4
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,15 @@ async def query(
4848
query_cache_manager: QueryCacheManager = Depends(get_query_cache_manager),
4949
headers: Annotated[str | None, Header()] = None,
5050
) -> Response:
51-
span_name = (
52-
f"v2_query_{data_source}_dry_run" if dry_run else f"v2_query_{data_source}"
53-
)
51+
span_name = f"v2_query_{data_source}"
52+
if dry_run:
53+
span_name += "_dry_run"
54+
if cache_enable:
55+
span_name += "_cache_enable"
56+
5457
with tracer.start_as_current_span(
5558
name=span_name, kind=trace.SpanKind.SERVER, context=build_context(headers)
56-
):
59+
) as span:
5760
try:
5861
sql = pushdown_limit(dto.sql, limit)
5962
except Exception as e:
@@ -89,6 +92,7 @@ async def query(
8992
cache_hit = cached_result is not None
9093

9194
if cache_hit:
95+
span.add_event("cache hit")
9296
response = ORJSONResponse(to_json(cached_result))
9397
response.headers["X-Cache-Hit"] = str(cache_hit).lower()
9498
return response

0 commit comments

Comments
 (0)