Skip to content

Commit df4bee4

Browse files
committed
release 2023.1: updated the release notes and test
1 parent b7bc973 commit df4bee4

File tree

2 files changed

+23
-5
lines changed

2 files changed

+23
-5
lines changed

docs/release-notes.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,19 @@
77
- [Notes on next version](next-release-details.md)
88

99
## Version 2023.1
10-
- 2022.3.0 - (Dec 2022)
10+
- 2022.3.0 - (May 2023)
1111
- docker tag: `latest`, `2022.3`, `2022.3.0`
1212

1313
### _Notes_
14-
#### This release some significant new features and code clean up
14+
#### This release includes some significant new features, existing feature improvements, and code clean up
1515

1616
#### New Features
1717
- TAP Upload: [Firefly-1142](https://github.com/Caltech-IPAC/firefly/pull/1317), [Firefly-1148](https://github.com/Caltech-IPAC/firefly/pull/1331), [Firefly-1189](https://github.com/Caltech-IPAC/firefly/pull/1337)
1818
- Improve TAP UI: [Firefly-1215](https://github.com/Caltech-IPAC/firefly/pull/1354)
1919
- Improved Click to search UI: [Firefly-1152](https://github.com/Caltech-IPAC/firefly/pull/1326)
2020
- Improved Derived columns UI: [Firefly-1153](https://github.com/Caltech-IPAC/firefly/pull/1330)
2121
- Improved Charting and Spectral UI layout: [Firefly-1183](https://github.com/Caltech-IPAC/firefly/pull/1348)
22-
- Improve 3-color selection: [Firefly-1134](https://github.com/Caltech-IPAC/firefly/pull/1310)
22+
- Improved 3-color selection: [Firefly-1134](https://github.com/Caltech-IPAC/firefly/pull/1310)
2323
- UWS support: [Firefly-1128](https://github.com/Caltech-IPAC/firefly/pull/1308), [Firefly-1129](https://github.com/Caltech-IPAC/firefly/pull/1319)
2424
- Faster image loading: [Firefly-1190](https://github.com/Caltech-IPAC/firefly/pull/1338)
2525
- Table of loaded image available in pinned image section: [Firefly-1081](https://github.com/Caltech-IPAC/firefly/pull/1344)

src/firefly/js/util/__tests__/VOAnalyzer-test.js

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,29 @@ describe('VOAnalyzer:', () => {
4545
expect(actual.lonCol).toEqual('ra1');
4646
expect(actual.latCol).toEqual('dec1');
4747

48+
// test ra_obj/dec_obj
49+
table.tableData.columns = [
50+
{name: 'ra_obj'},
51+
{name: 'dec_obj'},
52+
];
53+
actual = findTableCenterColumns(table);
54+
expect(actual).toBeTruthy();
55+
expect(actual.lonCol).toEqual('ra_obj');
56+
expect(actual.latCol).toEqual('dec_obj');
57+
58+
59+
// test fail
60+
table.tableData.columns = [
61+
{name: 'my_ra_unrecognized'},
62+
{name: 'my_dec_unrecognized'}
63+
];
64+
actual = findTableCenterColumns(table);
65+
expect(actual).toBeFalsy();
4866

4967
// test fail
5068
table.tableData.columns = [
51-
{name: 'ra_unrecognized'},
52-
{name: 'dec_unrecognized'}
69+
{name: 'rastuff'},
70+
{name: 'decstuff'}
5371
];
5472
actual = findTableCenterColumns(table);
5573
expect(actual).toBeFalsy();

0 commit comments

Comments
 (0)