DM-8302 response to review comments

tgoldina · tgoldina · commit d93887206c4c · 2017-01-06T08:35:02.000-08:00
diff --git a/src/firefly/js/charts/ui/Histogram.jsx b/src/firefly/js/charts/ui/Histogram.jsx
@@ -77,7 +77,6 @@ export class Histogram extends React.Component {
                 let doUpdate = false;
                 if (height !== nextProps.height || width !== nextProps.width ) {
                     chart.setSize(nextProps.width, nextProps.height, false);
-                    return false;
                 }
 
                 if (desc !== nextProps.desc) {
@@ -99,8 +98,8 @@ export class Histogram extends React.Component {
                 this.error = error;
                 chart.showLoading(error);
             }
-            return false;
         }
+        return false;
     }
 
     /*

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,6 @@ export class Histogram extends React.Component {`
`77`	`77`	`let doUpdate = false;`
`78`	`78`	`if (height !== nextProps.height \|\| width !== nextProps.width ) {`
`79`	`79`	`chart.setSize(nextProps.width, nextProps.height, false);`
`80`		`- return false;`
`81`	`80`	`}`
`82`	`81`
`83`	`82`	`if (desc !== nextProps.desc) {`
`@@ -99,8 +98,8 @@ export class Histogram extends React.Component {`
`99`	`98`	`this.error = error;`
`100`	`99`	`chart.showLoading(error);`
`101`	`100`	`}`
`102`		`- return false;`
`103`	`101`	`}`
	`102`	`+ return false;`
`104`	`103`	`}`
`105`	`104`
`106`	`105`	`/*`