Skip to content

Commit 42cbc1d

Browse files
author
Cindy Wang
committed
DM-9394 detecting 'showTables' only which handling 'table loaded' action in Firefly viewer manager.
1 parent e1a6957 commit 42cbc1d

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/firefly/js/templates/fireflyviewer/FireflyViewerManager.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,12 +129,11 @@ function onAnyAction(layoutInfo, action, views) {
129129

130130
function handleNewTable(layoutInfo, action) {
131131
const {tbl_id} = action.payload;
132-
var {images={}, showImages, showTables, hasTables} = layoutInfo;
132+
var {images={}, showImages, showTables} = layoutInfo;
133133
var {coverageLockedOn, showFits, showMeta, showCoverage, selectedTab, metaDataTableId} = images;
134134
const isMeta = isMetaDataTable(tbl_id);
135-
const isDisplayTable = (hasTables && showTables);
136135

137-
if ((isMeta || isCatalogTable(tbl_id)) && isDisplayTable ) {
136+
if ((isMeta || isCatalogTable(tbl_id)) && showTables ) {
138137
if (!showFits) {
139138
// only show coverage if there are not images or coverage is showing
140139
showFits= shouldShowFits();
@@ -144,7 +143,7 @@ function handleNewTable(layoutInfo, action) {
144143
showImages = true;
145144
}
146145
}
147-
if (isMeta && isDisplayTable) {
146+
if (isMeta && showTables) {
148147
showImages = true;
149148
selectedTab = 'meta';
150149
showMeta = true;

src/firefly/js/ui/ChartSelectDropdown.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ export class ChartSelectDropdown extends Component {
233233

234234
render() {
235235
const {tblId, tblStatsData} = this.state;
236-
236+
237237
return tblId ? (
238238
<ChartSelect {...{tblId, tblStatsData}} {...this.props}/>
239239
) : (

0 commit comments

Comments
 (0)