response to review comments

Author: tgoldina

src/firefly/js/metaConvert/LsstSdssRequestList.js

@@ -8,6 +8,7 @@ import {ZoomType} from '../visualize/ZoomType.js';
 import {WebPlotRequest, TitleOptions} from '../visualize/WebPlotRequest.js';
 import {ServerRequest} from '../data/ServerRequest.js';
 import {ServerParams} from '../data/ServerParams.js';
+import {toMaxFixed} from '../util/MathUtil.js';
 
 /**
  * This method returns a WebRequest object
@@ -17,6 +18,9 @@ import {ServerParams} from '../data/ServerParams.js';
  * @returns {WebPlotRequest} a web plot request
  */
 const bandMap= {u:0, g:1,r:2,i:3, z:4};
+
+const DECDIGIT = 4;
+
 function makeWebRequest(sr,  plotId, title) {
     const r  = WebPlotRequest.makeProcessorRequest(sr, 'lsst-sdss');
     const rangeValues= RangeValues.makeRV({which:SIGMA, lowerValue:-2, upperValue:10, algorithm:STRETCH_LINEAR});
@@ -56,7 +60,8 @@ function makeCcdReqBuilder(table, rowIdx) {
     return (plotId, id, filterName) => {
         sr.setParam('filterName', `${filterName}`);
         const scienceCCCdId = id.toString();
-        const title =scienceCCCdId.substr(0, 4) + bandMap[filterName].toString() + scienceCCCdId.substr(5, 10)+'-'+filterName+(subsize ? ` size: ${subsize}(deg)` : '');
+        const title =scienceCCCdId.substr(0, 4) + bandMap[filterName].toString() + scienceCCCdId.substr(5, 10)+
+            '-'+filterName+(subsize ? ` size: ${toMaxFixed(subsize,DECDIGIT)}(deg)` : '');
         return makeWebRequest(sr, plotId,  title);
     };
 }
@@ -87,7 +92,7 @@ function makeCoadReqBuilder(table, rowIdx) {
     return (plotId, id, filterName) => {
         sr.setParam('filterName', `${filterName}`);
         const deepCoaddId = id + bandMap[filterName];
-        const title = deepCoaddId+'-'+filterName+(subsize ? ` size: ${subsize}(deg)` : '');
+        const title = deepCoaddId+'-'+filterName+(subsize ? ` size: ${toMaxFixed(subsize,DECDIGIT)}(deg)` : '');
         return makeWebRequest(sr, plotId,  title);
     };
 }

src/firefly/js/ui/SizeInputField.jsx

@@ -6,6 +6,7 @@ import {convertAngle} from '../visualize/VisUtil.js';
 import {InputFieldView} from './InputFieldView.jsx';
 import {ListBoxInputFieldView} from './ListBoxInputField.jsx';
 import Validate from '../util/Validate.js';
+import {toMaxFixed} from '../util/MathUtil.js';
 import validator from 'validator';
 
 const invalidSizeMsg = 'size is not set properly or size is out of range';
@@ -16,20 +17,13 @@ function getUnit(unit) {
     return unitSign[unit];
 }
 
-/*
- * remove trailing zero from toFixed result
- */
-function toMaxFixed(floatNum, digits) {
-    return parseFloat(floatNum.toFixed(digits));
-}
-
 // input: string format,
 // output: size in degree (string foramt, no decimal digit limit), '': invalid input
 export const sizeToDeg = (sizestr, unit) => {
     if (sizestr && !validator.isFloat(sizestr)) {
         return sizestr;
     }
-    return (sizestr) ? toMaxFixed(convertAngle(((unit) ? unit : 'deg'), 'deg', sizestr), DECDIGIT).toString() : '';
+    return (sizestr) ? convertAngle(((unit) ? unit : 'deg'), 'deg', sizestr).toString() : '';
 };
 
 // input: size in degree string format

src/firefly/js/util/MathUtil.js

@@ -1,13 +1,10 @@
-/**
- * @author tatianag
- */
 /*
  Get the format string for a number, given an interval between the adjacent numbers
  and the number of significant digits you'd like to preserve in this interval
  */
 export const getFormatString = function(range, numSigDigits) {
 
-    if (range==0) { return '0'; }
+    if (range===0) { return '0'; }
 
     var format; // string format
 
@@ -32,3 +29,9 @@ export const getFormatString = function(range, numSigDigits) {
     return format;
 };
 
+/*
+ * remove trailing zero from toFixed result
+ */
+export function toMaxFixed(floatNum, digits) {
+    return parseFloat(Number(floatNum).toFixed(digits));
+}