Skip to content

Commit 138efde

Browse files
Merge pull request #1789 from Caltech-IPAC/FIREFLY-1762,1767,IRSA-6939-spherex-wording
FIREFLY-1762,1767,IRSA-6939: SPHEREx: wording changes and "coming soon"-ify Spectrophotometry
2 parents e4d3182 + b092756 commit 138efde

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

src/firefly/js/core/background/JobMonitor.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ function ControlRenderer({cellInfo}) {
242242

243243
function Delete({job}) {
244244
const doDelete = () => {
245-
showYesNoPopup('Are you sure that you want to delete this Job?',(id, yes) => {
245+
showYesNoPopup('Are you sure that you want to delete this job?',(id, yes) => {
246246
if (yes) dispatchJobRemove(job?.meta?.jobId);
247247
dispatchHideDialog(id);
248248
});

src/firefly/js/templates/hydra/HydraViewer.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import {LandingPage} from 'firefly/templates/fireflyviewer/LandingPage.jsx';
3232
import {Stacker} from 'firefly/ui/Stacker.jsx';
3333
import {setIf as setIfUndefined} from 'firefly/util/WebUtil.js';
3434
import {handleInitialAppNavigation} from 'firefly/templates/common/FireflyLayout';
35-
import {hexColorWithAlpha} from 'firefly/util/Color';
35+
import {joyVarColorWithAlpha} from 'firefly/util/Color';
3636

3737

3838
/*
@@ -187,7 +187,7 @@ const defaultPropsWithBgImage = ({bgImage}) => ({
187187
const darkPalette = theme.colorSchemes.dark.palette;
188188
return {
189189
maxWidth: '56rem', m: 'auto',
190-
backgroundColor: hexColorWithAlpha(darkPalette.background.surface.split(', ')?.[1]?.slice(0, -1) ?? '#000', 0.6),
190+
backgroundColor: joyVarColorWithAlpha(darkPalette.background.surface, 0.6),
191191
backdropFilter: 'blur(1px)',
192192
'.MuiTypography-body-md, .MuiTypography-body-lg': { color: darkPalette.text.secondary },
193193
'.MuiTypography-h2': { color: darkPalette.text.primary },

src/firefly/js/ui/CutoutSizeDialog.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -374,12 +374,12 @@ const StandardCutoutControls= ({cutoutTypeFieldKey, cutoutCenterWP, cutoutType,o
374374
}}/>
375375
{cutoutType===SEARCH_POSITION &&
376376
<Typography color='warning' level='body-sm'>
377-
Warning: If search position is not on the source image then the cutout will use row position
377+
Warning: If search position is not on the source image, then the cutout will use row position.
378378
</Typography>
379379
}
380380
{cutoutType!==USER_ENTERED_POSITION &&
381381
<Typography level='body-sm'>
382-
You may also click on the image to change position
382+
You may also click on the image to change position.
383383
</Typography>
384384
}
385385
<OptionalTarget cutoutCenterWP={cutoutCenterWP}

src/firefly/js/util/Color.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export const toRGB= (color) => chroma.valid(color) ? chroma(color).rgb() : [0,0,
1414
export const getRGBA= (color) => chroma.valid(color) ? chroma(color).rgba() : [0,0,0,1];
1515

1616
export const hexColorWithAlpha = (color, alpha) => chroma.valid(color) ? chroma(color).alpha(alpha).hex() : color;
17-
17+
export const joyVarColorWithAlpha = (joyVarColor, alpha) => hexColorWithAlpha(joyVarColor.split(', ')?.[1]?.slice(0, -1) ?? joyVarColor, alpha);
1818

1919
export const brighter = (colorStr,level=1) =>
2020
chroma.valid(colorStr) ? chroma(colorStr).brighten(level).toString() : undefined;

src/firefly/js/util/WebUtil.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1021,3 +1021,4 @@ export function createBackgroundRunner({
10211021
} );
10221022
}
10231023

1024+
export const varStr = (str) => '${' + str + '}';

0 commit comments

Comments
 (0)