Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/8821 cdt3 plugin colors #8831

Closed

Conversation

Abhishek-Atole
Copy link

Title: Fix color handling in CDT_3 plugin

Summary of Changes

This pull request fixes the color handling in the CDT_3 plugin where constrained facets and domains were not being properly colored. The implementation now correctly distinguishes between constrained and non-constrained facets, and properly colors inside and outside domains according to CGAL's visualization conventions.

Release Management

  • Affected package(s): Lab
  • Issue(s) solved: fix CGAL Lab CDT_3 plugin: fix the colors #8821
  • Feature/Small Feature: None
  • Link to compiled documentation: N/A (bug fix)
  • License and copyright ownership: [Your Name] - This contribution is made under the terms of the license of CGAL (GPL/LGPL).

@sloriot
Copy link
Member

sloriot commented Apr 7, 2025

This looks like to an AI generated patch. What is written makes no sense to me (won't compile for sure).

@sloriot sloriot closed this Apr 7, 2025
@MaelRL MaelRL added the Invalid label Apr 7, 2025
@Abhishek-Atole Abhishek-Atole deleted the fix/8821-cdt3-plugin-colors branch April 7, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CGAL Lab CDT_3 plugin: fix the colors
3 participants