Skip to content

Commit cc0a783

Browse files
xflordHejdaJakub
authored andcommitted
fix: fix TODO mdc-migration notes
* dealt with mdc-migration TODOs * a lot of the comments related to unused styles, deleted those * only issues with the comments were fixed, there a lot more related issues that will be fixed in other commits
1 parent 863de5c commit cc0a783

File tree

8 files changed

+4
-110
lines changed

8 files changed

+4
-110
lines changed

apps/admin-gui/src/app/shared/components/dialogs/add-user-ext-source-dialog/add-user-ext-source-dialog.component.scss

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,6 @@
88
margin-bottom: auto;
99
}
1010

11-
.auto-width {
12-
.mat-mdc-form-field {
13-
width: auto !important;
14-
}
15-
/* TODO(mdc-migration): The following rule targets internal classes of select that may no longer apply for the MDC version. */
16-
.mat-select-value {
17-
max-width: 100%;
18-
width: auto;
19-
}
20-
}
21-
2211
.pre-wrap {
2312
white-space: pre-wrap;
2413
}

apps/admin-gui/src/styles.scss

Lines changed: 3 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -866,31 +866,6 @@ textarea.cdk-textarea-autosize-measuring {
866866
background-color: #62727b;
867867
}
868868

869-
.white-color-input {
870-
color: #ffffff !important;
871-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version.*/
872-
.mat-form-field-label {
873-
color: #ffffff !important;
874-
}
875-
876-
.mat-focused {
877-
color: #ffffff !important;
878-
background-color: #ffffff !important;
879-
}
880-
881-
input {
882-
caret-color: #ffffff !important;
883-
}
884-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version.*/
885-
.mat-form-field-underline {
886-
background-color: #ffffff !important;
887-
}
888-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version.*/
889-
.mat-form-field-ripple {
890-
background-color: #ffffff !important;
891-
}
892-
}
893-
894869
.dialog-container {
895870
display: flex;
896871
flex-direction: column;
@@ -1389,8 +1364,7 @@ textarea.cdk-textarea-autosize-measuring {
13891364
// HACKS
13901365

13911366
// Dont show horizontal scroll at menu items
1392-
/* TODO(mdc-migration): The following rule targets internal classes of tabs that may no longer apply for the MDC version.*/
1393-
.mat-tab-body-content {
1367+
.mat-mdc-tab-body-content {
13941368
overflow: hidden !important;
13951369
}
13961370

@@ -1659,15 +1633,13 @@ mat-dialog-container:has(#loading-dialog-spinner) {
16591633
word-wrap: break-word !important;
16601634
}
16611635

1662-
/* TODO(mdc-migration): The following rule targets internal classes of tabs that may no longer apply for the MDC version.*/
1663-
.mat-tab-label {
1636+
.mdc-tab__text-label {
16641637
font-size: 16px !important;
16651638
color: black !important;
16661639
opacity: 1 !important;
16671640
}
16681641

1669-
/* TODO(mdc-migration): The following rule targets internal classes of tabs that may no longer apply for the MDC version.*/
1670-
.mat-tab-icon {
1642+
.mdc-tab__icon {
16711643
font-size: 16px !important;
16721644
}
16731645

apps/consolidator/src/styles.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,7 @@ mat-dialog-container:has(#loading-dialog-spinner) {
250250
background-color: black;
251251
}
252252

253-
/* TODO(mdc-migration): The following rule targets internal classes of chips that may no longer apply for the MDC version.*/
254-
mat-chip-list {
253+
mat-mdc-chip-grid {
255254
pointer-events: none;
256255
}
257256

apps/user-profile/src/app/pages/settings-page/settings-overview/settings-overview.component.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* TODO(mdc-migration): The following rule targets internal classes of list that may no longer apply for the MDC version. */
21
mat-list-item:hover {
32
background: var(--side-hover) !important;
43
color: var(--side-text-hover) !important;

libs/perun/dialogs/src/lib/add-ssh-dialog/add-ssh-dialog.component.scss

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -5,27 +5,3 @@
55
.white-space-pre {
66
white-space: pre-wrap;
77
}
8-
9-
perun-web-apps-add-ssh-dialog .mat-mdc-form-field {
10-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
11-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
12-
.mat-form-field-wrapper {
13-
padding-bottom: 0;
14-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
15-
.mat-form-field-underline {
16-
position: initial !important;
17-
display: block;
18-
margin-top: -1px;
19-
}
20-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
21-
.mat-form-field-subscript-wrapper,
22-
.mat-form-field-ripple {
23-
position: initial !important;
24-
display: table;
25-
}
26-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
27-
.mat-form-field-subscript-wrapper {
28-
min-height: calc(1em + 1px);
29-
}
30-
}
31-
}

libs/perun/dialogs/src/lib/change-expiration-dialog/change-expiration-dialog.component.scss

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,3 @@
66
.bottom-padding {
77
padding-bottom: 20px;
88
}
9-
10-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
11-
::ng-deep .mat-mdc-form-field.mat-focused .mat-form-field-underline {
12-
display: none;
13-
}

libs/perun/dialogs/src/lib/request-change-data-quota-dialog/request-change-data-quota-dialog.component.scss

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,6 @@
1616
width: 4rem;
1717
}
1818

19-
/* To remove the default underline */
20-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
21-
.mat-input-underline.mat-form-field-underline {
22-
display: none;
23-
}
24-
25-
/* To remove the underline ripple */
26-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
27-
.mat-input-ripple.mat-form-field-ripple {
28-
display: none;
29-
}
30-
3119
// fxLayout="row"
3220
.flex-row {
3321
display: flex;

libs/perun/namespace-password-form/src/lib/password-form/password-form.component.scss

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -14,27 +14,3 @@
1414
mat-icon:hover {
1515
cursor: default;
1616
}
17-
18-
:host ::ng-deep .mat-mdc-form-field {
19-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
20-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
21-
.mat-form-field-wrapper {
22-
padding-bottom: 0;
23-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
24-
.mat-form-field-underline {
25-
position: initial !important;
26-
display: block;
27-
margin-top: -1px;
28-
}
29-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
30-
.mat-form-field-subscript-wrapper,
31-
.mat-form-field-ripple {
32-
position: initial !important;
33-
display: table;
34-
}
35-
/* TODO(mdc-migration): The following rule targets internal classes of form-field that may no longer apply for the MDC version. */
36-
.mat-form-field-subscript-wrapper {
37-
min-height: calc(1em + 1px);
38-
}
39-
}
40-
}

0 commit comments

Comments
 (0)