Skip to content

Commit aecd28a

Browse files
committed
fix(admin): fix ExpressionChangedAfterItHasBeenCheckedError on applications page
* correctly set loading before loading of preferences and update after changes in dynamic list
1 parent 307fde6 commit aecd28a

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

apps/admin-gui/src/app/shared/components/application-actions/application-actions.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ export class ApplicationActionsComponent implements OnInit {
107107
) {}
108108

109109
@Input() set viewPreferences(att: Attribute) {
110+
this.loading$ = of(true);
110111
if ((att?.value as Array<string>)?.length > 0) {
111112
this.configuredColumns = att.value as Array<string>;
112113
this.configuredFedColumns = this.configuredColumns.filter((column) =>

libs/perun/components/src/lib/applications-dynamic-list/applications-dynamic-list.component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ export class ApplicationsDynamicListComponent implements OnInit, OnChanges, Afte
145145
if (this.dataSource) {
146146
this.child.paginator.pageIndex = 0;
147147
this.loadApplicationsPage();
148+
this.loading$.emit(this.dataSource.loading$);
148149
}
149150
this.selection.clear();
150151
}

0 commit comments

Comments
 (0)