fix: attribute values casting

* corrected attribute value cast

Author: bodnara

apps/admin-gui/src/app/shared/components/dialogs/create-sponsored-member-dialog/create-sponsored-member-dialog.component.ts

@@ -145,7 +145,7 @@ export class CreateSponsoredMemberDialogComponent implements OnInit {
             .filter((attr) => attr.friendlyNameParameter === namespace)
             .filter((attr) => attr.value !== null)
             .forEach((attr) => {
-              this.loginThatWasSet = attr.value as unknown as string;
+              this.loginThatWasSet = attr.value as string;
             });
         }
         this.loading = false;

apps/admin-gui/src/app/shared/components/dialogs/edit-email-footer-dialog/edit-email-footer-dialog.component.ts

@@ -44,7 +44,7 @@ export class EditEmailFooterDialogComponent implements OnInit {
 
   submit(): void {
     this.loading = true;
-    this.mailAttribute.value = this.mailFooter as unknown as object;
+    this.mailAttribute.value = this.mailFooter;
     if (this.data.groupId) {
       this.attributesManager
         .setGroupAttribute({ group: this.data.groupId, attribute: this.mailAttribute })
@@ -79,7 +79,7 @@ export class EditEmailFooterDialogComponent implements OnInit {
         this.mailAttribute = footer;
         this.editAuth = this.mailAttribute.writable;
         if (footer.value) {
-          this.mailFooter = footer.value as unknown as string;
+          this.mailFooter = footer.value as string;
         } else {
           this.mailFooter = '';
         }
@@ -93,7 +93,7 @@ export class EditEmailFooterDialogComponent implements OnInit {
         this.mailAttribute = footer;
         this.editAuth = this.mailAttribute.writable;
         if (footer.value) {
-          this.mailFooter = footer.value as unknown as string;
+          this.mailFooter = footer.value as string;
         } else {
           this.mailFooter = '';
         }

apps/admin-gui/src/app/shared/components/member-overview-groups/member-overview-groups.component.ts

@@ -93,7 +93,7 @@ export class MemberOverviewGroupsComponent implements OnChanges {
           this.groupMembershipDataSource = new MatTableDataSource<string>(['Status', 'Expiration']);
           this.expiration = !this.expirationAtt.value
             ? (this.translate.instant('MEMBER_DETAIL.OVERVIEW.NEVER_EXPIRES') as string)
-            : (this.expirationAtt.value as unknown as string);
+            : (this.expirationAtt.value as string);
         } else {
           this.groupMembershipDataSource = new MatTableDataSource<string>(['Status']);
         }

apps/admin-gui/src/app/shared/components/member-overview-membership/member-overview-membership.component.ts

@@ -100,7 +100,7 @@ export class MemberOverviewMembershipComponent implements OnChanges {
           this.voExpirationAtt = attr;
           this.voExpiration = !attr.value
             ? (this.translate.instant('MEMBER_DETAIL.OVERVIEW.NEVER_EXPIRES') as string)
-            : (attr.value as unknown as string);
+            : (attr.value as string);
           this.loading = false;
         },
         (error: HttpErrorResponse) => {

apps/admin-gui/src/app/shared/components/members-candidates-list/members-candidates-list.component.ts

@@ -201,7 +201,7 @@ export class MembersCandidatesListComponent implements OnChanges, AfterViewInit
         }
       }
       if (email?.value != null) {
-        return (email.value as unknown as string).replace(',', ' ');
+        return (email.value as string).replace(',', ' ');
       }
       return '';
     } else {
@@ -242,7 +242,7 @@ export class MembersCandidatesListComponent implements OnChanges, AfterViewInit
           }
           // parse login namespace
           const parsedNamespace: string = userAttribute.friendlyName.substring(16);
-          logins += parsedNamespace + ': ' + (userAttribute.value as unknown as string);
+          logins += parsedNamespace + ': ' + (userAttribute.value as string);
         }
       }
     }

apps/admin-gui/src/app/shared/pipes/any-to-string.pipe.ts

@@ -11,10 +11,10 @@ export class AnyToStringPipe implements PipeTransform {
     }
     switch (attribute.type) {
       case 'java.lang.String': {
-        return attribute.value as unknown as string;
+        return attribute.value as string;
       }
       case 'java.lang.Integer': {
-        return attribute.value as unknown as string;
+        return String(attribute.value);
       }
       case 'java.util.ArrayList': {
         return this.whenValueIsArray(attribute.value as string[]);
@@ -23,10 +23,10 @@ export class AnyToStringPipe implements PipeTransform {
         return this.whenValueIsMap(attribute.value as Map<string, string>);
       }
       case 'java.lang.Boolean': {
-        return attribute.value as unknown as string;
+        return String(attribute.value);
       }
       default: {
-        return attribute.value as unknown as string;
+        return String(attribute.value);
       }
     }
   }

apps/admin-gui/src/app/vos/components/application-detail/application-detail.component.ts

@@ -70,7 +70,7 @@ export class ApplicationDetailComponent implements OnInit {
                 const preferredMail = user.userAttributes.find(
                   (att) => att.friendlyName === 'preferredMail'
                 );
-                this.userMail = (preferredMail?.value as unknown as string) ?? '';
+                this.userMail = preferredMail?.value as string;
                 this.setAuthRights();
                 this.loading = false;
               });

apps/admin-gui/src/app/vos/pages/member-detail-page/member-overview/member-overview.component.ts

@@ -151,15 +151,15 @@ export class MemberOverviewComponent implements OnInit {
     if (this.member.memberAttributes !== null) {
       this.member.memberAttributes.forEach((att) => {
         if (this.attributeNames.includes(att.friendlyName)) {
-          this.attributes.set(att.friendlyName, [att.displayName, att.value as unknown as string]);
+          this.attributes.set(att.friendlyName, [att.displayName, att.value as string]);
         }
       });
     }
 
     if (this.member.userAttributes !== null) {
       this.member.userAttributes.forEach((att) => {
         if (this.attributeNames.includes(att.friendlyName)) {
-          this.attributes.set(att.friendlyName, [att.displayName, att.value as unknown as string]);
+          this.attributes.set(att.friendlyName, [att.displayName, att.value as string]);
         }
       });
     }

apps/publications/src/app/components/authors-list/authors-list.component.ts

@@ -134,7 +134,7 @@ export class AuthorsListComponent implements AfterViewInit, OnChanges {
     if (data.attributes) {
       data.attributes.forEach((attr) => {
         if (attr.friendlyName === nameOfAttribute) {
-          attribute = attr.value as unknown as string;
+          attribute = attr.value as string;
         }
       });
     }

apps/publications/src/app/pages/create-publication-page/create-single-publication-page/create-single-publication-page.component.ts

@@ -137,7 +137,7 @@ export class CreateSinglePublicationPageComponent implements OnInit {
         (user) => {
           const mailAtt = user.userAttributes.filter((att) => att.friendlyName === 'preferredMail');
           if (mailAtt.length !== 0) {
-            publicationInput.publication.createdBy = mailAtt[0].value as unknown as string;
+            publicationInput.publication.createdBy = mailAtt[0].value as string;
           }
 
           this.cabinetService.createPublication(publicationInput).subscribe(

apps/user-profile/src/app/app.component.ts

@@ -75,7 +75,7 @@ export class AppComponent implements OnInit, AfterViewInit {
       .getUserAttributes(this.store.getPerunPrincipal().userId)
       .subscribe((atts) => {
         const userPrefLang = atts.find((elem) => elem.friendlyName === 'preferredLanguage');
-        const userLang = (userPrefLang?.value as unknown as string) ?? null;
+        const userLang = (userPrefLang?.value as string) ?? null;
 
         const prefLang = this.preferredLangService.getPreferredLanguage(userLang);
         this.translateService.use(prefLang);

apps/user-profile/src/app/components/dialogs/add-auth-img-dialog/add-auth-img-dialog.component.ts

@@ -34,7 +34,7 @@ export class AddAuthImgDialogComponent implements OnInit {
   ngOnInit(): void {
     this.theme = this.data.theme;
     this.attribute = this.data.attribute;
-    this.newImage = this.attribute.value as unknown as string;
+    this.newImage = this.attribute.value as string;
   }
 
   handleInputChange(e: InputEvent): void {
@@ -98,7 +98,7 @@ export class AddAuthImgDialogComponent implements OnInit {
   }
 
   onAdd(): void {
-    this.attribute.value = this.newImage as unknown as object;
+    this.attribute.value = this.newImage;
     this.attributesManagerService
       .setUserAttribute({
         attribute: this.attribute,

apps/user-profile/src/app/components/dialogs/add-ssh-dialog/add-ssh-dialog.component.ts

@@ -54,7 +54,7 @@ export class AddSshDialogComponent implements OnInit {
   }
 
   onSubmit(): void {
-    const keys: string[] = (this.data.attribute?.value as unknown as string[]) ?? [];
+    const keys: string[] = (this.data.attribute?.value as string[]) ?? [];
     const ssh = this.sshControl.value as string;
     if (!keys.includes(ssh)) {
       keys.push(ssh);

apps/user-profile/src/app/components/dialogs/add-unix-group-dialog/add-unix-group-dialog.component.ts

@@ -42,7 +42,7 @@ export class AddUnixGroupDialogComponent implements OnInit {
         `urn:perun:user:attribute-def:def:preferredUnixGroupName-namespace:${this.data.namespace}`
       )
       .subscribe((attribute) => {
-        const groups: string[] = (attribute?.value as unknown as string[]) ?? [];
+        const groups: string[] = (attribute?.value as string[]) ?? [];
         groups.push(this.inputControl.value as string);
         attribute.value = groups;
 

apps/user-profile/src/app/components/dialogs/remove-string-value-dialog/remove-string-value-dialog.component.ts

@@ -44,9 +44,9 @@ export class RemoveStringValueDialogComponent implements OnInit {
   onSubmit(): void {
     this.loading = true;
     if (this.data.doNotShowValues) {
-      this.data.attribute.value = '' as unknown as object;
+      this.data.attribute.value = '';
     } else {
-      let values: string[] = (this.data.attribute?.value as unknown as string[]) ?? [];
+      let values: string[] = (this.data.attribute?.value as string[]) ?? [];
       if (this.data.valueIndex !== undefined) {
         values.splice(this.data.valueIndex, 1);
       } else {

apps/user-profile/src/app/components/membership-list/membership-list.component.ts

@@ -62,7 +62,7 @@ export class MembershipListComponent implements OnChanges, AfterViewInit {
       case 'description':
         return 'description' in data.entity ? data.entity.description : '';
       case 'expirationAttribute':
-        return (data?.expirationAttribute?.value as unknown as string) ?? 'never';
+        return (data?.expirationAttribute?.value as string) ?? 'never';
       default:
         return '';
     }

apps/user-profile/src/app/pages/identities-page/identities-page.component.ts

@@ -65,9 +65,9 @@ export class IdentitiesPageComponent implements OnInit {
             ues.userExtSource.id,
             'urn:perun:ues:attribute-def:def:sourceIdPName'
           )
-          .subscribe((att) => {
-            if (att?.value) {
-              ues.userExtSource.extSource.name = att.value as unknown as string;
+          .subscribe((sourceName) => {
+            if (sourceName?.value) {
+              ues.userExtSource.extSource.name = sourceName.value as string;
               count--;
               this.loading = count !== 0;
               this.addToList(ues);
@@ -77,10 +77,10 @@ export class IdentitiesPageComponent implements OnInit {
                   ues.userExtSource.id,
                   'urn:perun:ues:attribute-def:def:IdPOrganizationName'
                 )
-                .subscribe((att2) => {
+                .subscribe((orgName) => {
                   count--;
-                  if (att2?.value) {
-                    ues.userExtSource.extSource.name = att2.value as unknown as string;
+                  if (orgName?.value) {
+                    ues.userExtSource.extSource.name = orgName.value as string;
                   }
                   this.loading = count !== 0;
                   this.addToList(ues);

apps/user-profile/src/app/pages/profile-page/profile-page.component.ts

@@ -120,20 +120,20 @@ export class ProfilePageComponent implements OnInit {
         const emailAttribute = richUser.userAttributes.find(
           (att) => att.friendlyName === 'preferredMail'
         );
-        this.email = emailAttribute.value as unknown as string;
+        this.email = (emailAttribute?.value as string) ?? '-';
 
         this.languageAttribute = richUser.userAttributes.find(
           (att) => att.friendlyName === 'preferredLanguage'
         );
-        const userLang = (this.languageAttribute?.value as unknown as string) ?? null;
+        const userLang = (this.languageAttribute?.value as string) ?? null;
         const prefLang = this.preferredLangService.getPreferredLanguage(userLang);
         this.translateService.use(prefLang);
         this.currentLang = prefLang;
 
         this.timezoneAttribute = richUser.userAttributes.find(
           (att) => att.friendlyName === 'timezone'
         );
-        this.currentTimezone = (this.timezoneAttribute?.value as unknown as string) ?? '-';
+        this.currentTimezone = (this.timezoneAttribute?.value as string) ?? '-';
 
         const additionalAttributesSpecs: ProfileAttribute[] = this.storeService.get(
           'profile_page_attributes'
@@ -183,7 +183,7 @@ export class ProfilePageComponent implements OnInit {
   }
 
   setLanguage(): void {
-    this.languageAttribute.value = this.currentLang as unknown as object;
+    this.languageAttribute.value = this.currentLang;
     this.attributesManagerService
       .setUserAttribute({
         user: this.userId,
@@ -214,7 +214,7 @@ export class ProfilePageComponent implements OnInit {
   }
 
   setTimeZone(): void {
-    this.timezoneAttribute.value = this.currentTimezone as unknown as object;
+    this.timezoneAttribute.value = this.currentTimezone;
     this.attributesManagerService
       .setUserAttribute({
         user: this.userId,
@@ -243,7 +243,7 @@ export class ProfilePageComponent implements OnInit {
     this.attributesManagerService
       .getUserAttributeByName(this.userId, 'urn:perun:user:attribute-def:def:preferredMail')
       .subscribe((attribute) => {
-        this.email = attribute.value as unknown as string;
+        this.email = (attribute?.value as string) ?? '-';
       });
   }
 

apps/user-profile/src/app/pages/settings-page/settings-authorization/settings-authentication.component.ts

@@ -173,7 +173,7 @@ export class SettingsAuthenticationComponent implements OnInit, AfterViewInit {
               });
           } else {
             this.imgAtt = attr;
-            this.imageSrc = this.imgAtt.value as unknown as string;
+            this.imageSrc = this.imgAtt.value as string;
           }
           this.loadingImg = false;
         },

apps/user-profile/src/app/pages/settings-page/settings-mailing-lists/settings-mailing-lists.component.ts

@@ -138,10 +138,7 @@ export class SettingsMailingListsComponent implements OnInit, OnDestroy {
                     const attribute = resAtts.find(
                       (att) => att.friendlyName === 'optOutMailingList'
                     );
-                    if (
-                      attribute &&
-                      !(disableOptOut && (disableOptOut.value as unknown as string) === 'true')
-                    ) {
+                    if (attribute && !((disableOptOut?.value as string) === 'true')) {
                       this.optOuts.push({
                         resource: resource.id,
                         member: member.id,
@@ -169,7 +166,7 @@ export class SettingsMailingListsComponent implements OnInit, OnDestroy {
 
   unsubscribe(): void {
     const originalState = String(this.optOuts[this.index].attribute.value);
-    this.optOuts[this.index].attribute.value = 'true' as unknown as object;
+    this.optOuts[this.index].attribute.value = 'true';
     this.attributesManagerService.setMemberResourceAttribute(this.optOuts[this.index]).subscribe(
       () => {
         this.notificator.showSuccess(

apps/user-profile/src/app/pipes/validate-expiration.pipe.ts

@@ -7,6 +7,6 @@ import { Attribute } from '@perun-web-apps/perun/openapi';
 })
 export class ValidateExpirationPipe implements PipeTransform {
   transform(expirationAttribute: Attribute): string {
-    return (expirationAttribute?.value as unknown as string) ?? 'never';
+    return (expirationAttribute?.value as string) ?? 'never';
   }
 }

libs/perun/components/src/lib/attributes-list/attribute-value/attribute-value-integer/attribute-value-integer.component.ts

@@ -29,7 +29,7 @@ export class AttributeValueIntegerComponent implements OnInit {
     const config = getDefaultDialogConfig();
     config.width = '350px';
     config.data = {
-      value: attribute.value as unknown as string,
+      value: attribute.value as string,
       title: attribute.displayName,
     };
     this.dialog.open(ShowValueDialogComponent, config);

libs/perun/components/src/lib/attributes-list/attribute-value/attribute-value-map/attribute-value-map.component.ts

@@ -24,7 +24,9 @@ export class AttributeValueMapComponent implements OnInit {
 
   ngOnInit(): void {
     if (this.attribute.value) {
-      const map = this.attribute.value as Map<string, string>;
+      const map = new Map<string, string>(
+        Object.entries(this.attribute.value as { [s: string]: string })
+      );
       for (const [key, value] of map.entries()) {
         this.keys.push(key);
         this.values.push(value);

libs/perun/components/src/lib/attributes-list/attribute-value/attribute-value-string/attribute-value-string.component.ts

@@ -18,7 +18,7 @@ export class AttributeValueStringComponent implements OnInit {
   constructor(private dialog: MatDialog) {}
 
   ngOnInit(): void {
-    this.value = this.attribute.value as unknown as string;
+    this.value = this.attribute.value as string;
     if (!this.readonly) {
       this.readonly = isVirtualAttribute(this.attribute);
     }

libs/perun/components/src/lib/groups-list/groups-list.component.ts

@@ -428,6 +428,6 @@ export class GroupsListComponent implements AfterViewInit, OnChanges {
 
   getStatusAttribute(grp: RichGroup): string {
     const filter = grp.attributes.find((att) => att.baseFriendlyName === 'groupStatus');
-    return filter != null ? (filter.value as unknown as string) : '';
+    return filter !== null ? (filter.value as string) : '';
   }
 }

libs/perun/components/src/lib/user-ext-sources-list/user-ext-sources-list.component.ts

@@ -55,7 +55,7 @@ export class UserExtSourcesListComponent implements OnInit, OnChanges {
         return data.userExtSource.id.toString();
       case 'mail': {
         const attribute = data.attributes.find((att) => att.friendlyName === 'mail');
-        return attribute ? (attribute.value as unknown as string) : 'N/A';
+        return attribute ? (attribute.value as string) : 'N/A';
       }
       case 'extSourceName':
         return data.userExtSource.extSource.name;

libs/perun/dialogs/src/lib/change-group-expiration-dialog/change-group-expiration-dialog.component.ts

@@ -68,7 +68,7 @@ export class ChangeGroupExpirationDialogComponent implements OnInit {
     }
 
     this.expirationAttr = this.data.expirationAttr;
-    this.currentExpiration = (this.expirationAttr?.value as unknown as string) ?? 'never';
+    this.currentExpiration = (this.expirationAttr?.value as string) ?? 'never';
     this.newExpiration = this.currentExpiration;
 
     if (this.data.statusChanged) {
@@ -118,7 +118,7 @@ export class ChangeGroupExpirationDialogComponent implements OnInit {
         () => (this.loading = false)
       );
     } else {
-      this.expirationAttr.value = newExp === 'never' ? null : (newExp as unknown as object);
+      this.expirationAttr.value = newExp === 'never' ? null : newExp;
 
       this.attributesManagerService
         .setMemberGroupAttributes({