Skip to content

Commit 0815544

Browse files
committed
feat(admin): remove step-up window sign-in page
* removed sign-in page when step-up window is opened
1 parent ddd730a commit 0815544

File tree

4 files changed

+23
-2
lines changed

4 files changed

+23
-2
lines changed

apps/admin-gui/src/app/app.component.html

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
{{ warningMessage }}
44
</div>
55
<perun-web-apps-notificator [displayWarning]="displayWarning"></perun-web-apps-notificator>
6-
<ng-template [ngIf]="!isLoginScreenShow && !isServiceAccess && isLoggedIn()">
6+
<ng-template [ngIf]="!isLoginScreenShow && !isServiceAccess && isLoggedIn() && !isMfaWindowOpen">
77
<perun-web-apps-header
88
(sidenavToggle)="sidenav.toggle()"
99
[ngStyle]="{'top': getNavMenuTop(), 'background': navBackgroundColor}"
@@ -39,6 +39,12 @@
3939
</mat-sidenav-container>
4040
</ng-template>
4141

42-
<ng-template [ngIf]="isLoginScreenShow || isServiceAccess || !isLoggedIn()">
42+
<ng-template [ngIf]="isMfaWindowOpen">
43+
<div class="loader-wrapper">
44+
<div id="loader"></div>
45+
</div>
46+
</ng-template>
47+
48+
<ng-template [ngIf]="(isLoginScreenShow || isServiceAccess || !isLoggedIn()) && !isMfaWindowOpen">
4349
<perun-web-apps-login-screen-base [application]="'admin-gui'"></perun-web-apps-login-screen-base>
4450
</ng-template>

apps/admin-gui/src/app/app.component.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,8 @@ ng-scrollbar {
2727
--scrollbar-thumb: (106, 106, 106, 0.5);
2828
--scrollbar-thumb-hover-color: lightgrey;
2929
}
30+
31+
.loader-wrapper {
32+
display: block;
33+
height: 100vh;
34+
}

apps/admin-gui/src/app/app.component.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,8 @@ export class AppComponent implements OnInit, AfterViewInit {
5656
? 'calc(100vh - 112px)'
5757
: 'calc(100vh - 64px)';
5858

59+
isMfaWindowOpen = false;
60+
5961
constructor(
6062
private cache: CacheHelperService,
6163
private store: StoreService,
@@ -86,6 +88,10 @@ export class AppComponent implements OnInit, AfterViewInit {
8688
}
8789

8890
ngOnInit(): void {
91+
if (localStorage.getItem('mfaWindow')) {
92+
this.isMfaWindowOpen = true;
93+
return;
94+
}
8995
this.isLoginScreenShow = this.initAuth.isLoginScreenShown();
9096
this.isServiceAccess = this.initAuth.isServiceAccessLoginScreenShown();
9197
sessionStorage.removeItem('baLogout');

libs/perun/services/src/lib/mfa-handler.service.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ export class MfaHandlerService {
6565
sessionStorage.setItem('oldAccessToken', this.oauthService.getAccessToken());
6666
sessionStorage.setItem('oldRefreshToken', this.oauthService.getRefreshToken());
6767

68+
// set 'mfaWindow' property to session
69+
localStorage.setItem('mfaWindow', 'true');
6870
newWindow = this.setupMfaWindow();
6971

7072
if (newWindow) {
@@ -103,6 +105,8 @@ export class MfaHandlerService {
103105
localStorage.setItem('access_token', sessionStorage.getItem('oldAccessToken'));
104106
localStorage.setItem('refresh_token', sessionStorage.getItem('oldRefreshToken'));
105107
}
108+
// remove 'mfaWindow' property
109+
localStorage.removeItem('mfaWindow');
106110
return observer.next(true);
107111
}
108112
if (verificationSkipped) {

0 commit comments

Comments
 (0)