Customizable Time Limits for Alarm Challenges #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MarkisDev , @NishantSinghal19 can you please review this PR Thank you |
MarkisDev
requested changes
Mar 12, 2025
| @@ -406,17 +418,13 @@ class AlarmModel { | |||
| } | |||
|
|
|||
| String boolListToString(List<bool> boolList) { | |||
| // Rotate the list to start with Sunday | |||
There was a problem hiding this comment.
Bring back these comments, helps us keep track of the logic.
| @@ -157,7 +155,7 @@ class AlarmChallengeView extends GetView<AlarmChallengeController> { | |||
| ), | |||
| Obx( | |||
| () => Icon( | |||
| controller.isQrOngoing.value == | |||
| controller.isMathsOngoing.value == | |||
There was a problem hiding this comment.
why have you changed the flag?
| } | ||
| await Future.delayed(duration ~/ i); |
There was a problem hiding this comment.
It was done like this to keep the timer decreasing smoothly.
| void updateTimeLimit(int newLimit) { | ||
| challengeTimeLimit.value = newLimit; | ||
| if (alarmRecord != null) { | ||
| alarmRecord!.challengeTimeLimit = newLimit; |
There was a problem hiding this comment.
We dont need challenge time limit in alarm clock if we're moving this control to secure storage. If value is not present, use the default of 30s.
| apiKey.text = retrievedAPIKey; | ||
| } | ||
|
|
||
| // Store the retrieved weather state from the flutter secure storage |
There was a problem hiding this comment.
please add back these comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements customizable time limits for the challenges in our alarm app. Previously, the challenge duration was fixed (defaulting to 30 seconds). With these changes, users will be able to set their preferred duration via the challenge screen. The update includes modifications to the controller to store the user-defined time limit and changes to the view to let users update it.
Proposed Changes
alarm_challenge_controller.dart
alarm_challenge_view.dart
settings_controller.dart
settings_view.dart
Fixes #732
Screenshots
REC-20250310213646.mp4
Checklist