-
Notifications
You must be signed in to change notification settings - Fork 205
Added custom presets to timer #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi, @MarkisDev. Can you review this pr. |
@NishantSinghal19 can you check this pr and review it. |
@Vardhan-ysh The implementation seems fine, but I think we will have to work on the UI for this. It looks very different from what was proposed in the issue discussion, this UI will just end up being more confusing imo and users would think it's a bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to rework the UI part of this.
@MarkisDev , I tried following the ui I showcased but other things started glitching. I will try updating the UI for this page to look better. |
@Vardhan-ysh have you completed this implementation ?? |
There's a doubt I want to ask of you @MarkisDev and @Vardhan-ysh that the present_button you created was actually an imitation of the pre-existing file , hover_preset_button.dart right ?? so we don't actually need your file and only need to work on the hover_.....dart file right ? |
For the presets I only created the model file and changed the controller file. For the ui, I only edited the base files. I have been a little busy due to college exams so I have not been able to work on this. You can continue with this issue.The implementation part is working fine, you just need to update the ui for timer page so it is less confusing on how to use. |
Actually I have been thinking of adding new functionalities to it as well so I'll have to look into your code and see if i can reuse it in some way or not. Also is the file presets_button.dart even needed.. |
@Vardhan-ysh @VatsalJain2004 Hey guys, anyone working on it?? |
Description
Added custom presets to timer. Now we can add and save custom presets in the timer section. Now users can add custom presets to timer and then save them, so they don't have to enter the same time every time. Have attached the screen record.
WhatsApp.Video.2025-02-28.at.03.34.32_33e3890e.mp4
Fixes #656
Checklist