Skip to content

feat : added task swipe tour #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat : added task swipe tour #460

wants to merge 3 commits into from

Conversation

Mastermind-sap
Copy link
Contributor

@Mastermind-sap Mastermind-sap commented Mar 27, 2025 •
edited
Loading

Description

  • Added task swipe tour.
  • Also fixed certain previous versions of packages that were causing error building.

Fixes #459

Screenshots

image

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@Mastermind-sap Mastermind-sap changed the title Added task swipe tour feat : added task swipe tour Mar 31, 2025
@Pavel401
Copy link
Member

@SGI-CAPP-AT2 Please review this when you get time.

@SGI-CAPP-AT2 SGI-CAPP-AT2 self-requested a review May 26, 2025 14:47
SGI-CAPP-AT2
SGI-CAPP-AT2 requested changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@SGI-CAPP-AT2 SGI-CAPP-AT2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove generated or unintended files.
PR will be gtg then.

macos/Flutter/GeneratedPluginRegistrant.swift Outdated
@@ -14,7 +14,7 @@ import flutter_timezone
import package_info_plus
import path_provider_foundation
import shared_preferences_foundation
import sqflite_darwin
import sqflite
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mastermind-sap are these changes intended? if not, we should discard it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

@Mastermind-sap
Copy link
Contributor Author

Hey @SGI-CAPP-AT2 ,
Those changes occur when we compile for macOS. Those are intended and should not cause problems in future.

If you still want you can ignore those generated files.

SGI-CAPP-AT2
SGI-CAPP-AT2 approved these changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@SGI-CAPP-AT2 SGI-CAPP-AT2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and runs fine !

@Mastermind-sap
Copy link
Contributor Author

@SGI-CAPP-AT2 I have updated the gitignore and removed the generated files.

@SGI-CAPP-AT2 SGI-CAPP-AT2 self-requested a review May 29, 2025 01:13
SGI-CAPP-AT2
SGI-CAPP-AT2 requested changes May 29, 2025
View reviewed changes
Copy link
Collaborator

@SGI-CAPP-AT2 SGI-CAPP-AT2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Sorry for misunderstanding,
I wanted the files to be just discarded from that commit and not to be ignored using gitignore.
Do not add files to .gitignore instead do not stage them for commit manually
We should discuss about .gitignore changes in another issue.

@Mastermind-sap
Copy link
Contributor Author

@SGI-CAPP-AT2 I have removed the previous commit like you asked.

SGI-CAPP-AT2
SGI-CAPP-AT2 requested changes May 29, 2025
View reviewed changes
Copy link
Collaborator

@SGI-CAPP-AT2 SGI-CAPP-AT2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove those generated files

pubspec.lock Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this as well from commit

macos/Flutter/GeneratedPluginRegistrant.swift Outdated
@@ -14,7 +14,7 @@ import flutter_timezone
import package_info_plus
import path_provider_foundation
import shared_preferences_foundation
import sqflite_darwin
import sqflite
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

@Mastermind-sap
Copy link
Contributor Author

I cannot understand why I need to do this. Anyways I have done as you said @SGI-CAPP-AT2 .

@SGI-CAPP-AT2
Copy link
Collaborator

I cannot understand why I need to do this. Anyways I have done as you said @SGI-CAPP-AT2 .

Just to keep PR and commits clean
You can see how much changes are decreased by discarding the lock file. (From 800+ to only 241)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGI-CAPP-AT2 SGI-CAPP-AT2 SGI-CAPP-AT2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task Swipe Tutorial
3 participants
@Mastermind-sap @Pavel401 @SGI-CAPP-AT2