fix(BlockPlacer/MLG): add offhand support #5960
Open
+317
−259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MukjepScarlet
changed the title
superblaubeere27
requested changes
Apr 11, 2025
Comment on lines
52
to
61
| inline fun selectSlotSilently(requester: Any?, slot: HotbarItemSlot, ticksUntilReset: () -> Int): Hand { | ||
| return if (slot !is OffHandSlot) { | ||
| selectSlotSilently(requester, slot.hotbarSlot, ticksUntilReset()) | ||
| Hand.MAIN_HAND | ||
| } else { | ||
| Hand.OFF_HAND | ||
| } | ||
| } | ||
|
|
||
| fun selectSlotSilently(requester: Any?, slot: Int, ticksUntilReset: Int = 20) { |
There was a problem hiding this comment.
- There is no point in having two separate functions for doing the exact same thing. Just make the
selectSlotSilentlyfunction expect aHotbarItemSlotinstead of anIntin the first place. - The functional parameter
ticksUntilResetis a bit overkill. It is only used for callingrandom. A function with no side-effects and almost no computational complexity. Just calculaterandom()every time, even if it might also be anOffHandSlot.
There was a problem hiding this comment.
It's changed but I have a question: should we skip main hand slot index and offhand slot index directly in fun selectSlotSilently(requester: Any?, slot: Int, ticksUntilReset: Int)?
src/main/kotlin/net/ccbluex/liquidbounce/utils/inventory/Slots.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5956