Skip to content

Commit 65e6cd6

Browse files
author
BrightMountainMedia
authored
Revert "Update the checking rule of bid param for bridgewellBidAdapter (prebid#5736)"
This reverts commit b9f2c1b.
1 parent 10c741d commit 65e6cd6

File tree

2 files changed

+5
-37
lines changed

2 files changed

+5
-37
lines changed

modules/bridgewellBidAdapter.js

+5-7
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import find from 'core-js-pure/features/array/find.js';
55

66
const BIDDER_CODE = 'bridgewell';
77
const REQUEST_ENDPOINT = 'https://prebid.scupio.com/recweb/prebid.aspx?cb=' + Math.random();
8-
const BIDDER_VERSION = '0.0.3';
8+
const BIDDER_VERSION = '0.0.2';
99

1010
export const spec = {
1111
code: BIDDER_CODE,
@@ -19,13 +19,11 @@ export const spec = {
1919
*/
2020
isBidRequestValid: function (bid) {
2121
let valid = false;
22-
if (bid && bid.params) {
23-
if ((bid.params.cid) && (typeof bid.params.cid === 'number')) {
24-
valid = true;
25-
} else if (bid.params.ChannelID) {
26-
valid = true;
27-
}
22+
23+
if (bid && bid.params && bid.params.ChannelID) {
24+
valid = true;
2825
}
26+
2927
return valid;
3028
},
3129

test/spec/modules/bridgewellBidAdapter_spec.js

-30
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,6 @@ describe('bridgewellBidAdapter', function () {
2222
expect(spec.isBidRequestValid(validTag)).to.equal(true);
2323
});
2424

25-
it('should return true when required params found', function () {
26-
const validTag = {
27-
'bidder': 'bridgewell',
28-
'params': {
29-
'cid': 1234
30-
},
31-
};
32-
expect(spec.isBidRequestValid(validTag)).to.equal(true);
33-
});
34-
3525
it('should return false when required params not found', function () {
3626
const invalidTag = {
3727
'bidder': 'bridgewell',
@@ -49,26 +39,6 @@ describe('bridgewellBidAdapter', function () {
4939
};
5040
expect(spec.isBidRequestValid(invalidTag)).to.equal(false);
5141
});
52-
53-
it('should return false when required params are empty', function () {
54-
const invalidTag = {
55-
'bidder': 'bridgewell',
56-
'params': {
57-
'cid': '',
58-
},
59-
};
60-
expect(spec.isBidRequestValid(invalidTag)).to.equal(false);
61-
});
62-
63-
it('should return false when required param cid is not a number', function () {
64-
const invalidTag = {
65-
'bidder': 'bridgewell',
66-
'params': {
67-
'cid': 'bad_cid',
68-
},
69-
};
70-
expect(spec.isBidRequestValid(invalidTag)).to.equal(false);
71-
});
7242
});
7343

7444
describe('buildRequests', function () {

0 commit comments

Comments
 (0)