-
Notifications
You must be signed in to change notification settings - Fork 40
Cannot build latest tag 0.5.0
#52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hmm, is the issue that we have broken secp-zkp with minor releases of secp-sys? |
I think yes, this happens
|
I think we should just drop our explicit |
yeah right, sorry, what maybe what is needed is a point release ( Or a The pinning secp-sys is an hack I am using in a downstream lib |
I'm a bit confused what you mean by "a I can backport a fix though for 0.5.1. |
Ah, I understand, rust-secp-zkp*-sys* is not at 0.6.0. Oops. |
No, it is. @RCasatta are you able to bump to 0.6.0 or would you like me to create a 0.5.1? |
Sorry, I wrongly assumed 0.6.0 wasn't released because I didn't see a tag. If you can please tag 0.6.0 I can close this |
Sorry, it looks like I forgot to push the tag (it was there locally, which is why I couldn't figure out the problem). I've pushed it, things should be good now. |
All good! Thanks |
This fixes if we want to release 0.5.1
(FYI the error is also on the other tagged version but the
0.1.0
)The text was updated successfully, but these errors were encountered: