Use Cref.TryCreate in DocumentationReference

Author: a-gubskiy

src/BitzArt.XDoc/Models/Cref.cs

@@ -16,26 +16,25 @@ public Cref(string cref)
 
         var lastIndexOf = cref.LastIndexOf('.');
 
-        if (Prefix is "T:")
+        switch (Prefix)
         {
-            Type = cref.Substring(lastIndexOf + 1, cref.Length - lastIndexOf - 1);
-            Member = null;
-        }
-        else if (Prefix is "M:" or "P:" or "F:")
-        {
-            Type = cref.Substring(2, lastIndexOf - 2);
-            Member = cref.Substring(lastIndexOf + 1, cref.Length - lastIndexOf - 1);
-        }
-        else
-        {
-            throw new ArgumentException($"Invalid cref: {cref}");
+            case "T:":
+                Type = cref.Substring(lastIndexOf + 1, cref.Length - lastIndexOf - 1);
+                Member = null;
+                break;
+            case "M:" or "P:" or "F:":
+                Type = cref.Substring(2, lastIndexOf - 2);
+                Member = cref.Substring(lastIndexOf + 1, cref.Length - lastIndexOf - 1);
+                break;
+            default:
+                throw new ArgumentException($"Invalid cref: {cref}");
         }
 
         var typeLastIndexOf = Type.LastIndexOf('.');
 
         ShortType = Type.Substring(typeLastIndexOf + 1, Type.Length - typeLastIndexOf - 1);
     }
-    
+
     /// <summary>
     /// The prefix of the cref (e.g. "T:", "M:", "P:", "F:").
     /// </summary>
@@ -64,4 +63,24 @@ public override string ToString()
     {
         return $"{Prefix}{Type}{(Member != null ? "." + Member : string.Empty)}";
     }
+
+    /// <summary>
+    /// 
+    /// </summary>
+    /// <param name="value"></param>
+    /// <param name="cref"></param>
+    /// <returns></returns>
+    public static bool TryCreate(string? value, out Cref? cref)
+    {
+        try
+        {
+            cref = new Cref(value!);
+        }
+        catch
+        {
+            cref = null;
+        }
+
+        return cref != null;
+    }
 }

src/BitzArt.XDoc/Models/DocumentationReference.cs

@@ -27,11 +27,11 @@ public class DocumentationReference
     /// </summary>
     /// <param name="requirementNode"></param>
     /// <param name="target"></param>
-    /// <param name="cref"></param>
-    public DocumentationReference(XmlNode requirementNode, MemberDocumentation? target, string? cref)
+    /// <param name="crefValue"></param>
+    public DocumentationReference(XmlNode requirementNode, MemberDocumentation? target, string? crefValue)
     {
         Target = target;
         RequirementNode = requirementNode;
-        Cref = string.IsNullOrWhiteSpace(cref) ? null : new Cref(cref);
+        Cref = Cref.TryCreate(crefValue, out var cref) ? cref : null;
     }
 }