Fix cref. Update renderer.

Author: a-gubskiy

src/BitzArt.XDoc/Models/Cref.cs

@@ -19,7 +19,7 @@ public Cref(string cref)
         switch (Prefix)
         {
             case "T:":
-                Type = cref.Substring(lastIndexOf + 1, cref.Length - lastIndexOf - 1);
+                Type = cref.Substring(2, cref.Length - 2);
                 Member = null;
                 break;
             case "M:" or "P:" or "F:":

src/BitzArt.XDoc/Models/DocumentationReference.cs

@@ -29,9 +29,15 @@ public class DocumentationReference
     /// <param name="target"></param>
     /// <param name="crefValue"></param>
     public DocumentationReference(XmlNode requirementNode, MemberDocumentation? target, string? crefValue)
+        : this(requirementNode, target, Cref.TryCreate(crefValue, out var cref) ? cref : null)
+    {
+    }
+
+
+    public DocumentationReference(XmlNode requirementNode, MemberDocumentation? target, Cref? cref)
     {
         Target = target;
         RequirementNode = requirementNode;
-        Cref = Cref.TryCreate(crefValue, out var cref) ? cref : null;
+        Cref = cref;
     }
 }

src/BitzArt.XDoc/Models/Members/!TypeMemberDocumentation.cs

@@ -20,7 +20,7 @@ public abstract class TypeMemberDocumentation<TMember> : MemberDocumentation
     /// <summary>
     /// The <see cref="Type"/> that declares the member.
     /// </summary>
-    internal Type DeclaringType => _declaringTypeDocumentation.Type;
+    public Type DeclaringType => _declaringTypeDocumentation.Type;
 
     /// <summary>
     /// Name of the member.

src/EntityFrameworkCore/BitzArt.XDoc.EntityFrameworkCore/Extensions/PropertyBuilderExtensions.cs

@@ -15,8 +15,6 @@ public static class PropertyBuilderExtensions
     /// Adds a comment to a property being configured, using documentation from XDoc.
     /// The comment is extracted from a property defined in the provided expression.
     /// </summary>
-    /// <typeparam name="TEntity">The entity type being configured</typeparam>
-    /// <typeparam name="TProperty">The type of the property being configured</typeparam>
     /// <typeparam name="TCommentTargetEntity">The entity type containing the property whose documentation will be used</typeparam>
     /// <typeparam name="TCommentTargetProperty">The type of the property whose documentation will be used</typeparam>
     /// <param name="propertyBuilder">The builder for the property</param>
@@ -31,7 +29,7 @@ public static PropertyBuilder HasComment<TCommentTargetEntity, TCommentTargetPro
         Expression<Func<TCommentTargetEntity, TCommentTargetProperty>> commentTargetPropertyExpression)
         where TCommentTargetEntity : class
     {
-        var comment = xdoc.Get(commentTargetPropertyExpression).ToPlainText();;
+        var comment = xdoc.Get(commentTargetPropertyExpression).ToPlainText(forceSingleLine: true);
 
         return propertyBuilder.HasComment(comment);
     }
@@ -53,7 +51,7 @@ public static PropertyBuilder<TProperty> HasComment<TProperty, TCommentTargetEnt
         Expression<Func<TCommentTargetEntity, TCommentTargetProperty>> commentTargetPropertyExpression)
         where TCommentTargetEntity : class
     {
-        var comment = xdoc.Get(commentTargetPropertyExpression).ToPlainText();
+        var comment = xdoc.Get(commentTargetPropertyExpression).ToPlainText(forceSingleLine: true);
 
         return propertyBuilder.HasComment(comment);
     }

src/Render/BitzArt.XDoc.PlainText/PlainTextRenderer.cs

@@ -1,3 +1,4 @@
+using System.Reflection;
 using System.Text;
 using System.Xml;
 
@@ -182,15 +183,26 @@ private string RenderDocumentationReference(DocumentationReference documentation
         var text = documentationReference.Target switch
         {
             TypeDocumentation typeDocumentation => typeDocumentation.Type.Name,
-            FieldDocumentation fieldDocumentation => fieldDocumentation.MemberName,
-            PropertyDocumentation propertyDocumentation => propertyDocumentation.MemberName,
-            MethodDocumentation methodDocumentation => methodDocumentation.MemberName,
+            FieldDocumentation fieldDocumentation => RenderMember(fieldDocumentation),
+            PropertyDocumentation propertyDocumentation => RenderMember(propertyDocumentation),
+            MethodDocumentation methodDocumentation => RenderMember(methodDocumentation),
             _ => string.Empty
         };
 
         return text;
     }
 
+    private string RenderMember<T>(TypeMemberDocumentation<T> documentation)
+        where T : MemberInfo
+    {
+        if (_options.UseShortTypeNames)
+        {
+            return $"{documentation.DeclaringType.Name}.{documentation.MemberName}";
+        }
+
+        return $"{documentation.DeclaringType.FullName}.{documentation.MemberName}";
+    }
+
     /// <summary>
     /// Renders the content of an XML text node to plain text.
     /// </summary>