Skip to content

Commit 2a8fbac

Browse files
committed
Added data for ignore_above and test with fielddata true but no field.
Signed-off-by: MitchellGale-BitQuill <[email protected]>
1 parent dc48abe commit 2a8fbac

File tree

3 files changed

+22
-11
lines changed

3 files changed

+22
-11
lines changed

integ-test/src/test/java/org/opensearch/sql/sql/TextTypeIT.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,11 @@ public void aggregateOnKeywordFieldData() throws IOException {
5757
verifySchema(result,
5858
schema("sum(int0)", null, "integer"));
5959
}
60+
61+
@Test
62+
public void aggregateOnTextAndFieldDataNoFields() throws IOException {
63+
var result = executeJdbcRequest(String.format("select sum(int0) from %s GROUP BY textDataFieldNoFields", TEST_INDEX_TEXTKEYWORD));
64+
verifySchema(result,
65+
schema("sum(int0)", null, "integer"));
66+
}
6067
}

integ-test/src/test/resources/indexDefinitions/text_keyword_index_mapping.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"fields": {
1313
"keyword": {
1414
"type": "keyword",
15-
"ignore_above": 256
15+
"ignore_above": 10
1616
}
1717
} },
1818
"typeTextFieldData" : {
@@ -21,10 +21,14 @@
2121
"fields": {
2222
"keyword": {
2323
"type": "keyword",
24-
"ignore_above": 256
24+
"ignore_above": 10
2525
}
2626
}
2727
},
28+
"textDataFieldNoFields" : {
29+
"type": "text",
30+
"fielddata": true
31+
},
2832
"int0" : {
2933
"type": "integer"
3034
}
Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
{"index": {}}
2-
{"typeKeyword": "key00", "typeText": "text00", "typeKeywordFieldData": "keyFD00", "typeTextFieldData": "textFD00", "int0": 0}
2+
{"typeKeyword": "key00", "typeText": "text00", "typeKeywordFieldNoFieldData": "keyword00","typeTextFieldData": "keyFD00", "typeKeywordFieldData": "textFD00", "textDataFieldNoFields": "textFDNF00","int0": 0}
33
{"index": {}}
4-
{"typeKeyword": "key01", "typeText": "text01", "typeKeywordFieldData": "keyFD01", "typeTextFieldData": "textFD01", "int0": 1}
4+
{"typeKeyword": "key01", "typeText": "text01", "typeKeywordFieldNoFieldData": "keyword01", "typeTextFieldData": "keyFD01", "typeTextFieldData": "textFD01OverTen", "textDataFieldNoFields": "textFDNF01", "int0": 1}
5+
{"index": {},typeKeywordFieldData
6+
{"typeKeyword": "key02", "typeText": "text02", "typeKeywordFieldNoFieldData": "keyword02", "typeTextFieldData": "keyFD02", "typeKeywordFieldData": "textFD02", "textDataFieldNoFields": "textFDNF02", "int0": 2}
57
{"index": {}}
6-
{"typeKeyword": "key02", "typeText": "text02", "typeKeywordFieldData": "keyFD02", "typeTextFieldData": "textFD02", "int0": 2}
8+
{"typeKeyword": "key03", "typeText": "text03", "typeKeywordFieldNoFieldData": "keyword03", "typeTextFieldData": "keyFD03OverTen", "typeKeywordFieldData": "textFD03", "textDataFieldNoFields": "textFDNF03", "int0": 3}
79
{"index": {}}
8-
{"typeKeyword": "key03", "typeText": "text03", "typeKeywordFieldData": "keyFD03", "typeTextFieldData": "textFD03", "int0": 3}
10+
{"typeKeyword": "key04", "typeText": "text04", "typeKeywordFieldNoFieldData": "keyword04", "typeTextFieldData": "keyFD04", "typeKeywordFieldData": "textFD04", "textDataFieldNoFields": "textFDNF04", "int0": 4}
911
{"index": {}}
10-
{"typeKeyword": "key04", "typeText": "text04", "typeKeywordFieldData": "keyFD04", "typeTextFieldData": "textFD04", "int0": 4}
12+
{"typeKeyword": "key05", "typeText": "text05", "typeKeywordFieldNoFieldData": "keyword05", "typeTextFieldData": "keyFD05", "typeKeywordFieldData": "textFD0OverTen5", "textDataFieldNoFields": "textFDNF05", "int0": 5}
1113
{"index": {}}
12-
{"typeKeyword": "key05", "typeText": "text05", "typeKeywordFieldData": "keyFD05", "typeTextFieldData": "textFD05", "int0": 5}
14+
{"typeKeyword": "key06", "typeText": "text06", "typeKeywordFieldNoFieldData": "keyword06", "typeTextFieldData": "keyFD06OverTen", "typeKeywordFieldData": "textFD06", "textDataFieldNoFields": "textFDNF06", "int0": 6}
1315
{"index": {}}
14-
{"typeKeyword": "key06", "typeText": "text06", "typeKeywordFieldData": "keyFD06", "typeTextFieldData": "textFD06", "int0": 6}
15-
{"index": {}}
16-
{"typeKeyword": "key07", "typeText": "text07", "typeKeywordFieldData": "keyFD07", "typeTextFieldData": "textFD07", "int0": 7}
16+
{"typeKeyword": "key07", "typeText": "text07", "typeKeywordFieldNoFieldData": "keyword07", "typeTextFieldData": "keyFD07", "typeKeywordFieldData": "textFD07", "textDataFieldNoFields": "textFDNF07", "int0": 7}

0 commit comments

Comments
 (0)