Add feature testing script and feature testing for PR builds.

Author: BillyONeal

scripts/azure-pipelines/test-modified-features.ps1

@@ -0,0 +1,96 @@
+# Copyright (c) Microsoft Corporation.
+# SPDX-License-Identifier: MIT
+#
+
+<#
+.SYNOPSIS
+Runs the 'Test Modified Ports' part of the vcpkg CI system for all platforms.
+
+.PARAMETER Triplet
+The triplet to test.
+
+.PARAMETER WorkingRoot
+The location used as scratch space for 'installed', 'packages', and 'buildtrees' vcpkg directories.
+
+.PARAMETER FailureLogs
+The location to write failure logs. Defaults to current directory / failure-logs
+
+.PARAMETER ArchivesRoot
+Equivalent to '-BinarySourceStub "files,$ArchivesRoot"'
+
+.PARAMETER BinarySourceStub
+The type and parameters of the binary source. Shared across runs of this script. If
+this parameter is not set, binary caching will not be used. Example: "files,W:\"
+#>
+
+[CmdletBinding(DefaultParameterSetName="ArchivesRoot")]
+Param(
+    [Parameter(Mandatory = $true)]
+    [ValidateNotNullOrEmpty()]
+    [string]$Triplet,
+    [Parameter(Mandatory = $true)]
+    [ValidateNotNullOrEmpty()]
+    $WorkingRoot,
+    [ValidateNotNullOrEmpty()]
+    $FailureLogs = './failure-logs',
+    [Parameter(ParameterSetName='ArchivesRoot')]
+    $ArchivesRoot = $null,
+    [Parameter(ParameterSetName='BinarySourceStub')]
+    $BinarySourceStub = $null
+)
+
+if (-Not ((Test-Path "triplets/$Triplet.cmake") -or (Test-Path "triplets/community/$Triplet.cmake"))) {
+    Write-Error "Incorrect triplet '$Triplet', please supply a valid triplet."
+    exit 1
+}
+
+if ((-Not [string]::IsNullOrWhiteSpace($ArchivesRoot))) {
+    if ((-Not [string]::IsNullOrWhiteSpace($BinarySourceStub))) {
+        Write-Error "Only one binary caching setting may be used."
+        exit 1
+    }
+
+    $BinarySourceStub = "files,$ArchivesRoot"
+}
+
+$buildtreesRoot = Join-Path $WorkingRoot 'b'
+$installRoot = Join-Path $WorkingRoot 'installed'
+$packagesRoot = Join-Path $WorkingRoot 'p'
+
+$commonArgs = @(
+    "--x-buildtrees-root=$buildtreesRoot",
+    "--x-install-root=$installRoot",
+    "--x-packages-root=$packagesRoot",
+    "--overlay-ports=scripts/test_ports"
+)
+
+$cachingArgs = @()
+if ([string]::IsNullOrWhiteSpace($BinarySourceStub)) {
+    $cachingArgs = @('--no-binarycaching')
+} else {
+    $cachingArgs += "--binarysource=clear;$BinarySourceStub,readwrite"
+}
+
+if ($IsWindows) {
+    $vcpkgExe = './vcpkg.exe'
+} else {
+    $vcpkgExe = './vcpkg'
+}
+
+$ciBaselineFile = "$PSScriptRoot/../ci.feature.baseline.txt"
+$ciBaselineArg = "--ci-feature-baseline=$ciBaselineFile"
+
+if ($Triplet -eq 'x64-windows-release') {
+    $tripletArg = "--host-triplet=$Triplet"
+} else {
+    $tripletArg = "--triplet=$Triplet"
+}
+
+& $vcpkgExe x-check-features --for-merge-with origin/master $tripletArg "--failure-logs=$FailureLogs" $ciBaselineArg @commonArgs @cachingArgs
+$lastLastExitCode = $LASTEXITCODE
+if ($lastLastExitCode -ne 0)
+{
+    Write-Error "vcpkg feature testing failed; this is usually a bug in a port. Check for failure logs attached to the run in Azure Pipelines."
+}
+
+exit $lastLastExitCode

scripts/azure-pipelines/test-modified-ports.ps1

@@ -192,9 +192,6 @@ Add-ToolchainToTestCMake
 & $vcpkgExe ci $tripletArg "--failure-logs=$failureLogs" "--x-xunit=$xunitFile" $ciBaselineArg @commonArgs @cachingArgs @parentHashesArgs @skipFailuresArgs @allowUnexpectedPassingArgs
 $lastLastExitCode = $LASTEXITCODE
 
-$failureLogsEmpty = (-Not (Test-Path $failureLogs) -Or ((Get-ChildItem $failureLogs).Count -eq 0))
-Write-Host "##vso[task.setvariable variable=FAILURE_LOGS_EMPTY]$failureLogsEmpty"
-
 Write-Host "##vso[task.setvariable variable=XML_RESULTS_FILE]$xunitFile"
 
 if ($lastLastExitCode -ne 0)

scripts/azure-pipelines/windows/azure-pipelines.yml

@@ -69,8 +69,16 @@ jobs:
           $binarySas = az storage container generate-sas --name cache --account-name vcpkgbinarycachewus --as-user --auth-mode login --https-only --permissions rclw --expiry $end -o tsv | Out-String
           $binarySas = $binarySas.Trim()
           $env:X_VCPKG_ASSET_SOURCES = "x-azurl,https://vcpkgassetcachewus.blob.core.windows.net/cache,$assetSas,readwrite"
+          $binarySourceStub = "x-azblob,https://vcpkgbinarycachewus.blob.core.windows.net/cache,$binarySas"
+          $triplet = "${{ replace(parameters.jobName, '_', '-') }}"
           ./vcpkg.exe fetch python3
-          & scripts/azure-pipelines/test-modified-ports.ps1 -Triplet ${{ replace(parameters.jobName, '_', '-') }} -BuildReason $(Build.Reason) -BinarySourceStub "x-azblob,https://vcpkgbinarycachewus.blob.core.windows.net/cache,$binarySas" -WorkingRoot $env:WORKING_ROOT -ArtifactStagingDirectory $(Build.ArtifactStagingDirectory)
+          $failureLogs = '$(Build.ArtifactStagingDirectory)/failure-logs'
+          & scripts/azure-pipelines/test-modified-ports.ps1 -Triplet $triplet -BuildReason $(Build.Reason) -BinarySourceStub $binarySourceStub -WorkingRoot $env:WORKING_ROOT -ArtifactStagingDirectory $(Build.ArtifactStagingDirectory)
+          if ('$(Build.Reason)' -eq 'PullRequest') {
+            & scripts/azure-pipelines/test-modified-features.ps1 -Triplet $triplet -BinarySourceStub $binarySourceStub -WorkingRoot $env:WORKING_ROOT -FailureLogs $failureLogs
+          }
+          $failureLogsEmpty = (-Not (Test-Path $failureLogs) -Or ((Get-ChildItem $failureLogs).Count -eq 0))
+          Write-Host "##vso[task.setvariable variable=FAILURE_LOGS_EMPTY]$failureLogsEmpty"
   - task: PowerShell@2
     displayName: 'Validate version files'
     condition: eq('${{ replace(parameters.jobName, '_', '-') }}', '${{ variables.ExtraChecksTriplet }}')