Skip to content

Push and Pull of Parametric Sections and Beams #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Arne-Martensen
Copy link
Contributor

@Arne-Martensen Arne-Martensen commented Mar 22, 2023

Issues addressed by this PR

During the pushing process of multiple beams with different cross-sections, they were mistakenly pushed as multiple beams with equal cross-sections. Furthermore, there were issues with correctly pushing beams that had a T-shaped section. Standard L-shaped beams could not be pushed at all.

Closes #160

Test files

Test File Bar Push/Pull
Test File Section Push/Pull

Changelog

  • Added A Customized Comparator to compare BHoM Sections
  • Modified the reading writing of L-Sections

@Arne-Martensen Arne-Martensen added size:L Measured in days status:WIP PR in progress and still in draft, not ready for formal review labels Mar 22, 2023
@Arne-Martensen Arne-Martensen self-assigned this Mar 22, 2023
@Arne-Martensen Arne-Martensen changed the title First Push Push and Pull of Parametric Sections and Beams Mar 22, 2023
@Arne-Martensen Arne-Martensen marked this pull request as ready for review March 23, 2023 13:07
Copy link
Contributor

@staintono staintono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross Sections can be successfully pushed and pulled when using an empty RFEM model. This was tested by creating numerous bars with differing cross sections and pushing/pulling them in GH. The code was not reviewed.

@Arne-Martensen
Copy link
Contributor Author

@BHoMBot check compliance

@IsakNaslundBh IsakNaslundBh added type:bug Error or unexpected behaviour and removed status:WIP PR in progress and still in draft, not ready for formal review labels Mar 27, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 8 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 2 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 23 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit ce8929e into develop Mar 27, 2023
@FraserGreenroyd FraserGreenroyd deleted the RFEM_Toolkit-#160-Push_And_Pull_Of_Parametric_Sectionsand_Beams branch March 27, 2023 10:44
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L Measured in days type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push and Pull of Parametric Sections and Beams
4 participants