Skip to content

Get-Set Name property on structural elements #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2022

Conversation

MartinHenriksen
Copy link
Contributor

Issues addressed by this PR

Closes #18

For the Push and Pull between GH and RFEM a name property has been added in RFEM (can be seen in the comment section) for instances of Bar, Constraint, Material, Node and Panel. The name property can now be set RFEM and pulled into GH or vice versa.

Two Test files have been added (ToRFEM and FromRFEM). The From RFEM does also require an RFEM file, All files can be found under the link below.

Test files

Files

Changelog

  • Read/Write Name property added to Structural elements in RFEM_Toolkit

@MartinHenriksen MartinHenriksen changed the title Rfem toolkit #18 name property Get-Set Name property on structural elements Apr 28, 2022
@MartinHenriksen
Copy link
Contributor Author

Renamed merging branch for compliance. See original PR Here

Copy link
Contributor

@Arne-Martensen Arne-Martensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and new features tested using the test files supplied. All works as expected.

@MartinHenriksen
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 28, 2022

@MartinHenriksen to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 28, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 28, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 28, 2022

The check copyright-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@MartinHenriksen
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 29, 2022

@MartinHenriksen to confirm, the following checks are now queued:

  • ready-to-merge

There are 5 requests in the queue ahead of you.

@MartinHenriksen MartinHenriksen added the type:feature New capability or enhancement label Apr 29, 2022
@MartinHenriksen
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 29, 2022

@MartinHenriksen to confirm, the following checks are now queued:

  • ready-to-merge

There are 21 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Apr 29, 2022

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 6228822130

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 29, 2022

@FraserGreenroyd I'm sorry, but I cannot understand which check reference you are trying to provide. Please can you try again?

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Apr 29, 2022

@FraserGreenroyd I'm sorry, but I cannot understand which check reference you are trying to provide. Please can you try again?

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 2, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 2, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 2, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 2, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

There are 1 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 232f03c into main May 2, 2022
@FraserGreenroyd FraserGreenroyd deleted the RFEM_Toolkit-#18-NameProperty branch May 2, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFEM_Toolkit:add name property
3 participants