-
Notifications
You must be signed in to change notification settings - Fork 1
Get-Set Name property on structural elements #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rty For both FromRFEM and ToRFEM. In RFEM the name is stored in the comment section.
Renamed merging branch for compliance. See original PR Here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reviewed and new features tested using the test files supplied. All works as expected.
@BHoMBot check compliance |
@MartinHenriksen to confirm, the following checks are now queued:
|
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@MartinHenriksen to confirm, the following checks are now queued:
There are 5 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@MartinHenriksen to confirm, the following checks are now queued:
There are 21 requests in the queue ahead of you. |
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. |
@FraserGreenroyd I'm sorry, but I cannot understand which check reference you are trying to provide. Please can you try again? |
1 similar comment
@FraserGreenroyd I'm sorry, but I cannot understand which check reference you are trying to provide. Please can you try again? |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 2 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following checks are now queued:
There are 1 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #18
For the Push and Pull between GH and RFEM a name property has been added in RFEM (can be seen in the comment section) for instances of Bar, Constraint, Material, Node and Panel. The name property can now be set RFEM and pulled into GH or vice versa.
Two Test files have been added (ToRFEM and FromRFEM). The From RFEM does also require an RFEM file, All files can be found under the link below.
Test files
Files
Changelog