Skip to content

Disabling display of message on dropdown until a solution that works for Rhino7 is found #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #641

Disabling feature added in #640 until a solution working for all versions of rhino can be found in #642

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Oct 13, 2021
@IsakNaslundBh IsakNaslundBh self-assigned this Oct 13, 2021
@IsakNaslundBh IsakNaslundBh changed the title Comment out code crashing Rhino7 Disabling display of message on dropdown until a solution that works for Rhino7 is found Oct 13, 2021
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 13, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 13, 2021

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 14 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will review further through the 5.0 development milestone what else might need doing to allow us to fully support Grasshopper in Rhino 7.

@FraserGreenroyd FraserGreenroyd merged commit 859c259 into main Oct 13, 2021
@FraserGreenroyd FraserGreenroyd deleted the Grasshopper_Toolkit-#641-CommentOutDisplayCodeCrashingRhino7 branch October 13, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roll back feature to display Text on dropdown
3 participants