Adding nullable into extensions dir (#2203)

Co-authored-by: Franco Fung <[email protected]>

Author: 2 people

src/Microsoft.IdentityModel.KeyVaultExtensions/KeyVaultKeyWrapProvider.cs

@@ -39,14 +39,14 @@ public KeyVaultKeyWrapProvider(SecurityKey key, string algorithm)
         /// <param name="key">The <see cref="SecurityKey"/> that will be used for key wrap operations.</param>
         /// <param name="algorithm">The key wrap algorithm to apply.</param>
         /// <param name="client">A mock <see cref="IKeyVaultClient"/> used for testing purposes.</param>
-        internal KeyVaultKeyWrapProvider(SecurityKey key, string algorithm, IKeyVaultClient client)
+        internal KeyVaultKeyWrapProvider(SecurityKey key, string algorithm, IKeyVaultClient? client)
         {
             _algorithm = string.IsNullOrEmpty(algorithm) ? throw LogHelper.LogArgumentNullException(nameof(algorithm)) : algorithm;
             if (key == null)
                 throw LogHelper.LogArgumentNullException(nameof(key));
 
             _key = key as KeyVaultSecurityKey ?? throw LogHelper.LogExceptionMessage(new NotSupportedException(key.GetType().ToString()));
-            _client = client ?? new KeyVaultClient(new KeyVaultClient.AuthenticationCallback(_key.Callback));
+            _client = client ?? new KeyVaultClient(new KeyVaultClient.AuthenticationCallback(_key.Callback!));
         }
 
         /// <summary>
@@ -58,7 +58,7 @@ internal KeyVaultKeyWrapProvider(SecurityKey key, string algorithm, IKeyVaultCli
         /// Gets or sets a user context for a <see cref="KeyWrapProvider"/>.
         /// </summary>
         /// <remarks>This is null by default. This can be used by runtimes or for extensibility scenarios.</remarks>
-        public override string Context { get; set; }
+        public override string? Context { get; set; }
 
         /// <summary>
         /// Gets the <see cref="SecurityKey"/> that is being used.

src/Microsoft.IdentityModel.KeyVaultExtensions/KeyVaultSecurityKey.cs

@@ -17,7 +17,7 @@ namespace Microsoft.IdentityModel.KeyVaultExtensions
     public class KeyVaultSecurityKey : SecurityKey
     {
         private int? _keySize;
-        private string _keyId;
+        private string? _keyId;
 
         /// <summary>
         /// The authentication callback delegate which is to be implemented by the client code.
@@ -58,14 +58,14 @@ internal KeyVaultSecurityKey(string keyIdentifier, int keySize)
         /// <summary>
         /// The authentication callback delegate that retrieves an access token for the KeyVault.
         /// </summary>
-        public AuthenticationCallback Callback { get; protected set; }
+        public AuthenticationCallback? Callback { get; protected set; }
 
         /// <summary>
         /// The uniform resource identifier of the security key.
         /// </summary>
         public override string KeyId
         {
-            get => _keyId;
+            get => _keyId!;
             set
             {
                 if (string.IsNullOrEmpty(value))
@@ -90,7 +90,7 @@ public override int KeySize
                 if (!_keySize.HasValue)
                     Initialize();
 
-                return _keySize.Value;
+                return _keySize!.Value;
             }
         }
 
@@ -99,7 +99,7 @@ public override int KeySize
         /// </summary>
         private void Initialize()
         {
-            using (var client = new KeyVaultClient(new KeyVaultClient.AuthenticationCallback(Callback)))
+            using (var client = new KeyVaultClient(new KeyVaultClient.AuthenticationCallback(Callback!)))
             {
                 var bundle = client.GetKeyAsync(_keyId, CancellationToken.None).ConfigureAwait(false).GetAwaiter().GetResult();
                 _keySize = new BitArray(bundle.Key.N).Length;

src/Microsoft.IdentityModel.KeyVaultExtensions/KeyVaultSignatureProvider.cs

@@ -41,11 +41,11 @@ public KeyVaultSignatureProvider(SecurityKey key, string algorithm, bool willCre
         /// <param name="algorithm">The signature algorithm to apply.</param>
         /// <param name="willCreateSignatures">Whether this <see cref="KeyVaultSignatureProvider"/> is required to create signatures then set this to true.</param>
         /// <param name="client">A mock <see cref="IKeyVaultClient"/> used for testing purposes.</param>
-        internal KeyVaultSignatureProvider(SecurityKey key, string algorithm, bool willCreateSignatures, IKeyVaultClient client)
+        internal KeyVaultSignatureProvider(SecurityKey key, string algorithm, bool willCreateSignatures, IKeyVaultClient? client)
             : base(key, algorithm)
         {
             _key = key as KeyVaultSecurityKey ?? throw LogHelper.LogArgumentNullException(nameof(key));
-            _client = client ?? new KeyVaultClient(new KeyVaultClient.AuthenticationCallback(_key.Callback));
+            _client = client ?? new KeyVaultClient(new KeyVaultClient.AuthenticationCallback(_key.Callback!));
             WillCreateSignatures = willCreateSignatures;
 
             switch (algorithm)

src/Microsoft.IdentityModel.KeyVaultExtensions/Microsoft.IdentityModel.KeyVaultExtensions.csproj

@@ -10,6 +10,7 @@
     <TargetFrameworks Condition="'$(TargetNet8)' == 'True'">netstandard2.0;net6.0;net8.0</TargetFrameworks>
     <TargetFrameworks Condition="'$(TargetNet8)' != 'True'">netstandard2.0;net6.0</TargetFrameworks>
     <PackageTags>.NET;Windows;Authentication;Identity;Azure;Key;Vault;Extensions</PackageTags>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)'=='Debug'">

src/Microsoft.IdentityModel.LoggingExtensions/Microsoft.IdentityModel.LoggingExtensions.csproj

@@ -9,6 +9,7 @@
     <PackageId>Microsoft.IdentityModel.LoggingExtensions</PackageId>
     <PackageTags>.NET;Windows;Authentication;Identity;Extensions;Logging</PackageTags>
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)'=='Debug'">

src/Microsoft.IdentityModel.ManagedKeyVaultSecurityKey/Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.csproj

@@ -10,6 +10,7 @@
     <PackageId>Microsoft.IdentityModel.ManagedKeyVaultSecurityKey</PackageId>
     <TargetFrameworks>netstandard2.0</TargetFrameworks>
     <PackageTags>.NET;Windows;Authentication;Identity;Azure;Key;Vault;Extensions</PackageTags>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)'=='Debug'">

src/Microsoft.IdentityModel.TestExtensions/Microsoft.IdentityModel.TestExtensions.csproj

@@ -10,6 +10,7 @@
     <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
     <PackageId>Microsoft.IdentityModel.TestExtensions</PackageId>
     <SignAssembly>true</SignAssembly>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <ItemGroup>

src/Microsoft.IdentityModel.TestExtensions/TestTokenCreator.cs

@@ -136,7 +136,7 @@ public class TestTokenCreator
         /// <summary>
         /// Gets or sets the SigningCredentials used to sign the tokens created.
         /// </summary>
-        public SigningCredentials SigningCredentials { get; set; }
+        public SigningCredentials? SigningCredentials { get; set; }
 
         #region Create Test Token Methods
         /// <summary>