[VOQ LAG HLD] Updates for show commands #802
Conversation
Show commands section is updated to include syntax and sample output
|
@ ysmanman - could you please review , thanks |
doc/voq/lag_hld.md
Outdated
| Show VOQ system lags information | ||
|
|
||
| Options: | ||
| -d, --display [all] Show internal interfaces [default: all] |
There was a problem hiding this comment.
The help string is incorrect
There was a problem hiding this comment.
I'll fix this.
There was a problem hiding this comment.
Fixed. Removed "-d" option
doc/voq/lag_hld.md
Outdated
| Show VOQ system lags information | ||
|
|
||
| Options: | ||
| -d, --display [all] Show internal interfaces [default: all] |
There was a problem hiding this comment.
Since we are displaying internal lag information, I think we dont need the -d option.
There was a problem hiding this comment.
Yes. We do not need the -d option. I'll remove this.
doc/voq/lag_hld.md
Outdated
|
|
||
| Options: | ||
| -d, --display [all] Show internal interfaces [default: all] | ||
| -n, --namespace [] Namespace name or all |
There was a problem hiding this comment.
Can you elabarote what will the difference in output between the commands show chassis system-lags and show chassis system-lags -n asic0 ?
There was a problem hiding this comment.
The intention was to use this to display the lags from a specific asic. The system lag name includes the DEVICE_METADATA['localhost']['asic_name'] which is expected to be same as the namespace name. If not, this will not work.
Do you think we can remove this option?
There was a problem hiding this comment.
Fixed. Since the system lag info is retrieved form chassis app db, which in global name space in supervisor card (i.e., it is namespace agnostic), instead of using namespace option, an option is introduced to take the asic_name (this need not be namespace name) which is used for filtering the output for the given specific asic.
- "-d" option removed; Asic name option is provided instead of using namespace.
doc/voq/lag_hld.md
Outdated
| Show VOQ system lags information | ||
|
|
||
| Options: | ||
| -x, --asicname TEXT Asic name |
There was a problem hiding this comment.
why not use -n here ? similar to show chassis system_ports
There was a problem hiding this comment.
"-n" stands for "namespace". Only for system ports we get the system ports config info from databases from specific namespace. The "-x" option stands for "switch or asic". This is for getting info form chassis data bases in the supervisor card which is not in any specific namespace. The "-x" option is used for getting entries that have the given asic name in their keys. It is not used for accessing databases from different namespaces.
There was a problem hiding this comment.
@vganesan-nokia. Thanks for the explanation.
The option is little confusing for me. For example the output for the command show chassis system-lags -x asic0 will display lags which have asic0 in the key from all linecards. Is this correct ?
Would it simple if we provide option to filter on linecard iso of asic ?
There was a problem hiding this comment.
@vganesan-nokia. Thanks for the explanation.
The option is little confusing for me. For example the output for the commandshow chassis system-lags -x asic0will display lags which haveasic0in the key from all linecards. Is this correct ?
[@vganesan-nokia] correct
Would it simple if we provide option to filter on linecard iso of asic ?
[@vganesan-nokia ] Even though we filter on specific asic, the entries will be shown with the full key, which includes the 'hostname'. So we can identify which asic is from which linecard (assuming 'hostname' has the string that identifies the linceard)
We can replace the "asicname" option. by filtering on 'hostname'. The asic name is the value of the mandatory attribute DEVICE_METADATA['localhost']['asic_name']. So we have this filter on asic name. For 'linecard' we do not have such thing. However, in the multi slot chassis system we have a convention (not a written rule but kind of best practice) of using the mandatory attribute DEVICE_METADATA['localhost']['hostname'] to identify linecard/slot. This 'hostname' must be unique within the chassis. This is following the model of non chassis multi-asic box where the 'hostname' holds the name of the box. In chassis systems since each card acts as a multi asic box, this convention is followed.
I feel that instead of replacing 'asicname' by 'hostname', we can have 'hostname' as additional option so that we can filter on entries for specific asic from a specific line card or entries from all asics of a specific line card. If you feel that this is too much filtering, I'll replace 'asicname' by 'hostname'.
There was a problem hiding this comment.
Fixed. Added option for filtering on host or linecard name.
Added -t <host or linecard name> option to "show chassis system-lags" command
Changed the asicname option selector to "-n" from "-x". Changed hostname to linecardname and the option selector to "-l" from "-t"
Show commands section is updated to include syntax and sample output