[BGP] Static routes require Ack to be send from fpmsyncd #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
previously approved these changes
Jan 8, 2024
doc/BGP/BGP-supress-fib-pending.md
Outdated
| @@ -111,7 +111,7 @@ High level requirements: | |||
| Restrictions/Limitations: | |||
|
|
|||
| - MPLS, VNET routes are out of scope of this document | |||
| - Directly connected and static routes are announced by BGP regardless of their offload status | |||
| - Directly connected are announced by BGP regardless of their offload status | |||
There was a problem hiding this comment.
Directed connected routes?
There was a problem hiding this comment.
C>* 100.1.0.0/24 is directly connected, Ethernet160, 00:33:18
There was a problem hiding this comment.
Sorry, I meant the below highlighted update.
Directly connected routes are announced by BGP regardless of their offload status
There was a problem hiding this comment.
Oh, thanks for catching this!
volodymyrsamotiy
approved these changes
Jan 11, 2024
venkatmahalingam
approved these changes
Jan 12, 2024
prsunny
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wrong statement, static routes do require Ack to be advertised.