gracefully exit out of error condition when retrieving device ip address #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
fixes an issue where fast reboot fails when an interface ip has been removed
- How I did it
added code to catch exception when fast reboot script retrieves an interface ip that has been removed
- How to verify it
remove an interface ip address using ifconfig and issue fast reboot
- Previous command output (if the output of a command-line utility has changed)
admin@sonic:~$ sudo fast-reboot -y
Failed to run fast-reboot-dump.py. Exit code: 2
- New command output (if the output of a command-line utility has changed)
admin@sonic:~$ sudo fast-reboot -y
-->