Configure Max NTP Server limit #3311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root-cause : NTP Server max limit has not been conifgured. What I did : Maximum NTP Server limit has been configured as 10 with an error message Signed-off-by: Reshman Bablo B <[email protected]>
Signed-off-by: reshmanbablo <[email protected]>
Signed-off-by: reshmanbablo <[email protected]>
Signed-off-by: reshmanbablo <[email protected]>
Signed-off-by: reshmanbablo <[email protected]>
|
Commenter does not have sufficient privileges for PR 3311 in repo sonic-net/sonic-utilities |
|
@liat-grozovik @saiarcot895 |
|
Looks like the HLD you linked to is on a private branch. Is there a HLD PR link? |
|
In the current NTP HLD (https://github.com/sonic-net/SONiC/blob/master/doc/ntp/ntp-design.md), I don't see any such limitation. |
|
Thanks for the pointing out @saiarcot895 . I haven't verified with latest HLD. |
|
@saiarcot895 Actually src/sonic-yang-models/yang-models/sonic-ntp.yang has mentioned the max-elements as 10 in NTP_SERVER_LIST with description mentioned in Excessive Number of Upstream Time Servers. Is this yang need to be corrected? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Maximum NTP Server limit has been added as 10 with an appropriate error message.
Ref : NTP Scalability Requirements
How I did it
In config/main.py, Validation code has been added to check whether the maximum NTP server limit is reached or not .
An error message has been added when it exceeds the limit.
How to verify it
Issue
config ntp add <ip_address>10 times.After the max limit , error message
Error: Max elements limit 10 reached.will be thrown.Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)