[DPB] Enhance the code to shutdown interface before delete ports #2521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhancement done in this commit: Check the admin status on the ports to be deleted. If the port admin status is up, do shutdown ports. If the port admin status is down, do nothing. Wait until the admin status of the ports to be removed on state DB has changed to down. Signed-off-by: chiourung_huang [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Make sure the port shutdown is done before delete the port.
How I did it
Check the admin status on the ports to be deleted.
If the port admin status is up, do shutdown ports.
If the port admin status is down, do nothing.
Wait until the admin status of the ports to be removed on state DB has changed to down.
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
Signed-off-by: chiourung_huang [email protected]