Skip to content

[sonic-installer]: Align command name style #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marian-pritsak
Copy link
Collaborator

Other commands also use dash instead of underscore

Signed-off-by: marian-pritsak [email protected]

Copy link
Contributor

@taoyl-ms taoyl-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to take backward compatibility into consideration here - there could be user scripts that has dependency on the name of this binary and we might not afford to make the change.

Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need back-ward compatible.

@marian-pritsak
Copy link
Collaborator Author

Will it be ok to create symlink with old name?

@lguohan
Copy link
Contributor

lguohan commented Jan 16, 2018

symbol link is ok.

vdahiya12 pushed a commit to vdahiya12/sonic-utilities that referenced this pull request Jul 23, 2021
Xcvrd crashes when pushing QSFP DD DOM info to state DB.

#### Description
**xcvrd crash log:**
     “May 6 05:12:37.446235 S1G2 ERR pmon#xcvrd[5292]: This functionality is currently not implemented for this platform”
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
Testbeds using the mux simulator will see lots of error messages in the syslog since many y_cable methods are not mocked for the mux simulator. This PR prepares `y_cable.py` to use mocked methods that will be introduced in a future sonic-mgmt PR.

Signed-off-by: Lawrence Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants