Don't return error when execute "portstat -d" #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If execute "portstat -d" without execute "portstat" first,
then this command would fail due to "No such file or directory"
Before fix:
root@as5812-54x:/home/admin# portstat -d
Traceback (most recent call last):
File "/usr/bin/portstat", line 411, in <module>
main()
File "/usr/bin/portstat", line 355, in main
if os.listdir(cnstat_dir) == []:
OSError: [Errno 2] No such file or directory: '/tmp/portstat-0'
Signed-off-by: chiourung_huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If execute "portstat -d" without execute "portstat" first,
then this command would fail due to "No such file or directory"
- What I did
Don't return error when there is no directory or file.
- How to verify it
Boot the DUT and execute "portstat -d"
- Previous command output
root@as5812-54x:/home/admin# portstat -d
Traceback (most recent call last):
File "/usr/bin/portstat", line 411, in
main()
File "/usr/bin/portstat", line 355, in main
if os.listdir(cnstat_dir) == []:
OSError: [Errno 2] No such file or directory: '/tmp/portstat-0'
Signed-off-by: chiourung_huang [email protected]
- What I did
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)