Skip to content

[Warmboot] teamsyncd timer support 'disable' to skip teamd reconciliation #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dzhangalibaba
Copy link
Contributor

@dzhangalibaba dzhangalibaba commented Jul 26, 2020

[email protected]:~$ sudo config warm_restart teamsyncd_timer 0
Usage: config warm_restart teamsyncd_timer [OPTIONS] <seconds>

Error: teamsyncd warm restart timer must be in range 1-3600 or disable

[email protected]:~$ sudo config warm_restart teamsyncd_timer 1
[email protected]:~$ redis-cli -n 4 hgetall "WARM_RESTART|teamd"
1) "teamsyncd_timer"
2) "1"

[email protected]:~$ sudo config warm_restart teamsyncd_timer disabl
Usage: config warm_restart teamsyncd_timer [OPTIONS] <seconds>

Error: Invalid value for 'seconds': disabl is not a valid integer or 'disable'

[email protected]:~$ sudo config warm_restart teamsyncd_timer disable
[email protected]:~$ redis-cli -n 4 hgetall "WARM_RESTART|teamd"
1) "teamsyncd_timer"
2) "9999"
[email protected]:~$ sudo config warm_restart teamsyncd_timer 45
[email protected]:~$ show warm_restart config
name    enable    timer_name         timer_duration
------  --------  ---------------  ----------------
teamd   false     teamsyncd_timer                45
[email protected]:~$ sudo config warm_restart teamsyncd_timer disable
[email protected]:~$ show warm_restart config
name    enable    timer_name       timer_duration
------  --------  ---------------  ----------------
teamd   false     teamsyncd_timer  disable

Signed-off-by: Dong Zhang [email protected]

@dzhangalibaba
Copy link
Contributor Author

@yxieca

@yxieca yxieca requested review from jleveque, daall and arlakshm and removed request for jleveque and daall July 29, 2020 18:09
@dzhangalibaba dzhangalibaba changed the title [Warmboot] teamsyncd timer support 9999 to skip teamd reconciliation [Warmboot] teamsyncd timer support 'disable' to skip teamd reconciliation Jul 30, 2020
Copy link
Contributor

@pavel-shirshov pavel-shirshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment

pavel-shirshov
pavel-shirshov previously approved these changes Jul 31, 2020
@pavel-shirshov
Copy link
Contributor

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants