Skip to content

Gcov for swss daemon #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pettershao-ragilenetworks
Copy link
Contributor

@pettershao-ragilenetworks pettershao-ragilenetworks commented May 8, 2021

What I did
Introduce gcov-related automation script to test coverage rate for swss module
relate HLD: sonic-net/SONiC#642
Why I did it
Attempt to integrate coverage report for each module in SONiC to Azure pipeline
How I verified it
Using Azure pipeline to check whether a coverage report can be checked after a pull request
Details if related

@prsunny
Copy link
Collaborator

prsunny commented Oct 9, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pettershao-ragilenetworks
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 1737 in repo Azure/sonic-swss

@pettershao-ragilenetworks
Copy link
Contributor Author

@prsunny help forward,have rebuild done!

@prsunny
Copy link
Collaborator

prsunny commented Oct 18, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@theasianpianist
Copy link
Contributor

/Azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@theasianpianist
Copy link
Contributor

/Azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pettershao-ragilenetworks
Copy link
Contributor Author

hi @prsunny @theasianpianist help forward this, thanks!

@theasianpianist
Copy link
Contributor

/Azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Collaborator

prsunny commented Nov 4, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Collaborator

prsunny commented Nov 4, 2021

@xumia , could you please sign-off ?

Copy link
Contributor

@kcudnik kcudnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after this will be merged, may we check how much coverage this will generate for sonic-sairedis repo ? currently sairedis repo only runs local unittests which cover about 60% of the code, maybe running docker tests will bump that number up

@prsunny prsunny merged commit b20f0f4 into sonic-net:master Nov 5, 2021
@kcudnik
Copy link
Contributor

kcudnik commented Nov 8, 2021

@pettershao-ragilenetworks hey, can we try use this approach on sonic-sairedis repo ? to find out what coverage could be achieved, since current unittest cover on sairedis repo in 60%, i will write mail

@pettershao-ragilenetworks
Copy link
Contributor Author

@pettershao-ragilenetworks hey, can we try use this approach on sonic-sairedis repo ? to find out what coverage could be achieved, since current unittest cover on sairedis repo in 60%, i will write mail

OK!

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
include changes:
0031470 |  improve enum values integration check (sonic-net#1727) (sonic-net#1737)

Signed-off-by: richardyu-ms <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants