Skip to content

Switch Capability support #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PrabhuSreenivasan
Copy link
Contributor

@PrabhuSreenivasan PrabhuSreenivasan commented Dec 4, 2020

Signed-off-by: Prabhu Sreenivasan [email protected]

What I did
Added switch capability support where Orchagent queries the switch for the list of supported objects (SAI_SWITCH_ATTR_SUPPORTED_OBJECT_TYPE_LIST) and identifies the capabilities / features supported by the switch. It further updates the SWITCH_TABLE:switch on APPL_DB with supported capabilities

eg:

sonic-db-cli APPL_DB hgetall "SWITCH_TABLE:switch"
threshold_supported
True

Why I did it
This allows applications/users to understand whether a feature is supported on a device / SAI implementation.

How I verified it
Query SWITCH_TABLE:switch on APPL_DB for "threshold_supported" entry.

Related PRs
sonic-net/sonic-sairedis#728

Details if related

@PrabhuSreenivasan
Copy link
Contributor Author

The vslib support for the same is on sonic-net/sonic-sairedis#728.

@PrabhuSreenivasan
Copy link
Contributor Author

retest vs please

@PrabhuSreenivasan
Copy link
Contributor Author

@lguohan, Can you please add Label:brcm-upstream to this PR

Signed-off-by: Prabhu Sreenivasan <[email protected]>
@PrabhuSreenivasan
Copy link
Contributor Author

How can I fix the below failure? It seems to be coming on latest swss builds

@azure-pipelinesazure-pipelines
/ Azure.sonic-swss
Build log #L12
The container 9968994 could not be found.

@prsunny prsunny self-requested a review as a code owner September 2, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants