[schema] Add IS-IS and LDP config and alarms #528
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiluo-msft Could you review this PR please? |
prsunny
reviewed
Sep 10, 2021
| @@ -104,6 +104,18 @@ namespace swss { | |||
|
|
|||
| #define APP_NEIGH_RESOLVE_TABLE_NAME "NEIGH_RESOLVE_TABLE" | |||
|
|
|||
| #define APP_REJECTED_CONFIG "REJECTED_CONFIG" | |||
There was a problem hiding this comment.
This is too generic name. Please rename to a specific table that is intended
There was a problem hiding this comment.
It's a table to report configuration that's been rejected by one of the SONiC containers due to being malformed - so REJECTED_CONFIG is the specific name for it
There was a problem hiding this comment.
Which sonic container report this configuration? can you provide an HLD/doc that captures this implementation?
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
requested changes
Sep 16, 2021
| @@ -104,6 +104,18 @@ namespace swss { | |||
|
|
|||
| #define APP_NEIGH_RESOLVE_TABLE_NAME "NEIGH_RESOLVE_TABLE" | |||
|
|
|||
| #define APP_REJECTED_CONFIG "REJECTED_CONFIG" | |||
There was a problem hiding this comment.
Which sonic container report this configuration? can you provide an HLD/doc that captures this implementation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.