-
Notifications
You must be signed in to change notification settings - Fork 291
Test with coverage output, publish gcov on Azure pipelines #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Qi Luo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems much simpler than this preposition: https://github.com/Azure/sonic-swss/pull/1737/files
Will this change also include coverage during vstests run or this is only for local unit tests ?
should we consider disabling optimization when performing code coverage: https://gcc.gnu.org/onlinedocs/gcc/Gcov-and-Optimization.html |
seems like CODE_COVERAGE override that by default: |
@qiluo-msft in your build you get the same error:
to disable optimization |
maybe gcovr will need extra parameter "--exclude-throw-branches" explanation: gcovr/gcovr#283
Also for example compiling sonic-sairedis with -O0, will also need probably swss-common compiled with -O0, since there could be artefacts, for example sizeof(std::string) is different when compiled in -O2 and -O0 since it's contain more debug info and this could lead to some weird exceptions and crashes in code correction upper claim is actually mitigated by CODE_COVERAGE_CPPFLAGS which contains "-DNDEBUG" which prevents any issues, just code is compiled with -O0 but as production and not debug code |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
No description provided.