Add support for swig 4.0 in configure.ac #511
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test error on test_ConfigDBSubscribe not related to PR |
|
@arlakshm can you check this test_ConfigDBSubscribe ? |
|
I am working on fixing the test_ConfigDBSubscribe. |
qiluo-msft
reviewed
Jul 26, 2021
configure.ac
Outdated
| @@ -31,7 +31,7 @@ esac],[debug=false]) | |||
| AM_CONDITIONAL(DEBUG, test x$debug = xtrue) | |||
| AM_CONDITIONAL(ARCH64, test `getconf LONG_BIT` = "64") | |||
|
|
|||
| AC_PATH_PROG(SWIG, [swig3.0]) | |||
| AC_PATH_PROGS(SWIG, [swig3.0 swig]) | |||
There was a problem hiding this comment.
Is swig only for version 4.0? If it is a general one, do we still need swig3.0 ?
There was a problem hiding this comment.
not exactly sure, but latest 4.0 binary is "swig" but 3.0 is "swig3.0", this macro will check for both in this order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.