-
Notifications
You must be signed in to change notification settings - Fork 175
Modular chassis: Psud set master led on first run #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@judyjoseph Please review when you get a chance or add the component owner as reviewer. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@lguohan - could you please assign reviewer to this PR (Platform daemon related), thanks |
Hi @ysmanman - could you please review and approve as well, thanks. |
Staphylo
approved these changes
Sep 8, 2021
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@sujinmkang could you review? |
sujinmkang
approved these changes
Feb 11, 2022
judyjoseph
pushed a commit
that referenced
this pull request
Mar 20, 2022
On first run, the PSU master-led on supervisor of modular-chassis is not set. Description The PSU master-led on modular chassis indicates the power-buget status. Similar to individual PSU leds that are set on first_run, the master-led also will be set to based on initial status (RED or GREEN with LED status ON). Motivation and Context Without the forced setting of first_run, the master-led status will default to per vendor default. In some cases, this could be amber blinking etc
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
… host_electrical_interface, connector_dict (sonic-net#206) Due to wrong page selection, the eeprom read returned a value 0xff which was an invalid key into connector_dict[]. Now we verify the key validity before accessing the dict element. The fix for why the eeprom read returned 0xff is being investigated separately. Signed-off-by: Prince George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On first run, the PSU master-led on supervisor of modular-chassis is not set.
Description
The PSU master-led on modular chassis indicates the power-buget status. Similar to individual PSU leds that are set on first_run, the master-led also will be set to based on initial status (RED or GREEN with LED status ON).
Motivation and Context
Without the forced setting of first_run, the master-led status will default to per vendor default. In some cases, this could be amber blinking etc
How Has This Been Tested?
This has been tested on real HW and unit-tests using pytest suite.
Additional Information (Optional)