Fix memory map parsing issue for SFF8636 #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Sun <[email protected]>
keboliu
approved these changes
Jan 15, 2024
prgeor
approved these changes
Jan 18, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-common
that referenced
this pull request
Jan 18, 2024
Signed-off-by: Stephen Sun <[email protected]>
|
Cherry-pick PR to 202311: #428 |
mssonicbld
pushed a commit
that referenced
this pull request
Jan 18, 2024
Signed-off-by: Stephen Sun <[email protected]>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
|
Hi @stephenxs do you test this PR with 202305? @prgeor would you support this cherry pick to 202305? |
Yes, I did. |
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-common
that referenced
this pull request
Feb 7, 2024
Signed-off-by: Stephen Sun <[email protected]>
|
Cherry-pick PR to 202305: #438 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 7, 2024
Signed-off-by: Stephen Sun <[email protected]>
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix memory map parsing issue for SFF8636:
extendedcan not be parsed from10/40G Ethernet Compliance Codedue to being masked.The field
10/40G Ethernet Compliance Codeis a bit field but is parsed as an enumeration with the assumption that only 1 bit can be set, which fails to parse a value in case more than 1 bit is set. However, the bitextendedcan co-exist with bit40GBASE-CR4, which means the parsing logic can fail in such cases.In PR #412 the
extendedbit was masked out but it failed to parseextendedbit as a result.In this PR, the combination
extended+40GBASE-CR4is handled by adding the value to the enumeration.Motivation and Context
How Has This Been Tested?
Additional Information (Optional)