Fix CCmisApi identifier overrides ycable identifier in syslog. #409
+18
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdahiya12
suggested changes
Oct 24, 2023
vdahiya12
approved these changes
Oct 24, 2023
vdahiya12
approved these changes
Nov 4, 2023
vdahiya12
approved these changes
Nov 4, 2023
prgeor
reviewed
Nov 9, 2023
…github.com/xincunli-sonic/sonic-platform-common into xincun-sonic/fix-ccmispi-syslog-identifier
|
This should be addressed by this PR: sonic-net/sonic-buildimage#17171. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the CCmisApi overrides ycable as SYSLOG identifier when CCmisApi became the last caller of sonic-py-common/logger.py's syslog module.
Type of change
Approach
Use logging module instead of common logger to avoid overriding.
What is the motivation for this PR?
SysLog shows
NOTICE pmon#CCmisApi:instead ofNOTICE pmon#ycable:, which cause debug confusion and loganalysis wrong identified the component.How did you do it?
Removed the helper_logger from CCmisApi instead using logging directly.
How did you verify/test it?
Put the change into lab device, then inspect the syslog after restart ycabled daemon process.
Any platform specific information?
This is common issue when ycabled started.
Signed-off-by: Xincun Li [email protected]