[Credo][Ycable] update health_check() to enhance the accuracy #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abort count overlimit Signed-off-by: Xinyu <[email protected]>
Signed-off-by: Xinyu <[email protected]>
vdahiya12
reviewed
Jun 5, 2023
| if api_ver >= 0x18 and uart_stat['Local']['UART2']['RxErrorCnt'] > 100: | ||
| self.log_error("check cable health fail: uart rx error count overlimit:%d" % (uart_stat['local']['UART2']['RxErrorCnt'])) | ||
| if api_ver >= 0x18: | ||
| if uart_stat['Local']['UART2']['RxErrorCnt'] > 100: |
There was a problem hiding this comment.
could we check the uart_stat dictionary would have the keys ? and if not what to do ?
There was a problem hiding this comment.
My original concept is to use api_ver to avoid to hit KeyError (key is not exist in the dict). but, you are right, it is better to check if the key is exist or not. Let me submit one more commit to handle the exception
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
* [CMIS] Add power up duration for power up timeout Signed-off-by: chiourung_huang <[email protected]> * modify function name after code review --------- Signed-off-by: chiourung_huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fix will check UART retry/abort counts and fail it if those counters are over-limit.
The API, health_check() is used for RMA diagnostics.
Motivation and Context
To enhance health_check() accuracy
How Has This Been Tested?
Tested on Arista-7050CX3
Additional Information (Optional)