-
Notifications
You must be signed in to change notification settings - Fork 187
[sfp-refactor] Add initial support for SFF-8472 in sonic_xcvr #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
t_offset = decoded_deps.get(consts.T_OFFSET_FIELD) | ||
result = t_slope * measured_val + t_offset | ||
return result / self.scale | ||
return float('NaN') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this decoded value returned? float('NaN')?
@andywongarista please fix the build errors due to your changes:
|
@andywongarista i think sonic-mgmt tests for the API set_power_override() will fail since its not applicable for SFF-8472 https://github.com/Azure/sonic-mgmt/blob/master/tests/platform_tests/api/test_sfp.py#L516 |
|
@andywongarista following tests will fail for SFP, QSFP+, QSFP28 for platforms using SfpOptoeBase
Will you be able to fix this in the sfp-refactor code |
@andywongarista could you resolve merge conflict? |
1 similar comment
@andywongarista could you resolve merge conflict? |
Description
This PR adds basic support for the SFF-8472 transceiver spec within the new sonic_xcvr package.
Motivation and Context
See the HLD: Azure/SONiC#786
How Has This Been Tested?
Added new unit test under tests/sonic_xcvr
Verified API calls on an Arista platform
Additional Information (Optional)