[sonic-yang-mgmt] Adding in_place flag to sonic_yang.loadData #9224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@praveen-li Could you help review? |
qiluo-msft
reviewed
Nov 10, 2021
| returns: True - success False - failed | ||
| """ | ||
| def loadData(self, configdbJson, debug=False): | ||
| def loadData(self, configdbJson, debug=False, remove_non_yang_in_place=True): |
qiluo-msft
reviewed
Nov 10, 2021
| @@ -1038,16 +1039,21 @@ def _findXpathList(self, xpath, list, keys): | |||
| load_data: load Config DB, crop, xlate and create data tree from it. (Public) | |||
| input: data | |||
| debug Flag | |||
| remove_non_yang_in_place Flag that indicates whether to remove tables without YANG | |||
| from configdbJson directly or create a copy and modify it | |||
There was a problem hiding this comment.
Modify configdbJson directly or ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
sonic_yang.loadData was by default removing tables without YANG from the input configdbJson i.e. modifying it in place
How I did it
Added an
in_placeflag so caller ofloadDatacan decide whether to modify input in place or not.How to verify it
unit-test added