-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ci]: add native arm64/armhf sonic-slave build pipeline #9056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
setup sonic-slave template and use the template for amd64, arm64 and armhf sonic-slave Signed-off-by: Guohan Lu <[email protected]>
- bash: | | ||
set -ex | ||
|
||
SLAVE_DIR=sonic-slave-${{ parameters.dist }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can reuse the docker naming code in Makefile.work
set SLAVE_BASE_IMAGE after line 85
SLAVE_BASE_IMAGE = $(grep $SLAVE_BASE_TAG $tmpfile | grep "Successfully tagged" | cut -d' ' -f3 | cut -d: -f1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intend to keep it as line L63-L64 check if the platform/arch combination is supported or not.
- stage: Build | ||
jobs: | ||
- ${{ each dist in parameters.dists }}: | ||
- ${{ if contains(variables['Build.DefinitionName'], dist) }}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pipeline works for all dists in arm64 agent.
we shouldn't compare pipeline name and dist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think for arm64, we still want to create different pipeline for different slave dist.
Signed-off-by: Guohan Lu <[email protected]>
setup sonic-slave template and use the template
for amd64, arm64 and armhf sonic-slave
Signed-off-by: Guohan Lu [email protected]
Why I did it
build native docker for armhf and arm64
How I did it
move sonic-slave to template
How to verify it
run several pipeline.
sonic-slave-buster-arm64
sonic-slave-buster-armhf
https://dev.azure.com/mssonic/build/_build?definitionScope=%5Cbldenv
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)