Skip to content

[ci]: add native arm64/armhf sonic-slave build pipeline #9056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2021

Conversation

lguohan
Copy link
Collaborator

@lguohan lguohan commented Oct 25, 2021

setup sonic-slave template and use the template
for amd64, arm64 and armhf sonic-slave

Signed-off-by: Guohan Lu [email protected]

Why I did it

build native docker for armhf and arm64

How I did it

move sonic-slave to template

How to verify it

run several pipeline.

sonic-slave-buster-arm64
sonic-slave-buster-armhf

https://dev.azure.com/mssonic/build/_build?definitionScope=%5Cbldenv

image

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

liushilongbuaa
liushilongbuaa previously approved these changes Oct 26, 2021
setup sonic-slave template and use the template
for amd64, arm64 and armhf sonic-slave

Signed-off-by: Guohan Lu <[email protected]>
liushilongbuaa
liushilongbuaa previously approved these changes Oct 28, 2021
- bash: |
set -ex

SLAVE_DIR=sonic-slave-${{ parameters.dist }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can reuse the docker naming code in Makefile.work
set SLAVE_BASE_IMAGE after line 85
SLAVE_BASE_IMAGE = $(grep $SLAVE_BASE_TAG $tmpfile | grep "Successfully tagged" | cut -d' ' -f3 | cut -d: -f1)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intend to keep it as line L63-L64 check if the platform/arch combination is supported or not.

- stage: Build
jobs:
- ${{ each dist in parameters.dists }}:
- ${{ if contains(variables['Build.DefinitionName'], dist) }}:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pipeline works for all dists in arm64 agent.
we shouldn't compare pipeline name and dist.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think for arm64, we still want to create different pipeline for different slave dist.

qiluo-msft
qiluo-msft previously approved these changes Oct 28, 2021
Signed-off-by: Guohan Lu <[email protected]>
@lguohan lguohan merged commit 7cfce6f into sonic-net:master Nov 6, 2021
@lguohan lguohan deleted the arm64-slave branch November 6, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants