Skip to content

[iccpd]enhance for add_to_syncd #9014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[iccpd]enhance for add_to_syncd #9014

wants to merge 1 commit into from

Conversation

pettershao-ragilenetworks
Copy link
Contributor

Why I did it

Enhance for add_to_syncd not modified after add_mac_to_chip, if not enhance, may cause fdb removed in iccpd, but still exist in app_db and asic_db. check below code:

if (mac_info->add_to_syncd)
{
    del_mac_from_chip(mac_info);
}

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@pettershao-ragilenetworks
Copy link
Contributor Author

@Praveen-Brcm help review this, thanks!

1 similar comment
@pettershao-ragilenetworks
Copy link
Contributor Author

@Praveen-Brcm help review this, thanks!

@pettershao-ragilenetworks
Copy link
Contributor Author

@gechiang @qiluo-msft help forward this, thanks!

@gechiang
Copy link
Collaborator

gechiang commented Feb 8, 2022

@pettershao-ragilenetworks Can you also include test cases to ensure new changes are unit tested?
Issue such as this slipped because these were not properly tested (missing unit test code) when the code was first developed.
So going forward our request is to at the minimum to add unit test case that should exercise the portion of the code that you are modifying. once this is included, alert me to review. Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants