[mux] Add Mux Container To Master Branch #8838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahmed-dev
requested review from
lguohan,
theasianpianist,
prsunny and
yxieca
prsunny
reviewed
Sep 24, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
previously approved these changes
Sep 27, 2021
|
Azure Pipelines successfully started running 1 pipeline(s). |
lguohan
reviewed
Sep 27, 2021
lguohan
reviewed
Sep 27, 2021
Linkmgrd monitors link status, mux status, and link state. Has the link becomes unhealthy, linkmgrd will trigger mux switchover on a standby ToR ensuring uninterrupted service to servers/blades. This PR is initial implementation of linkmgrd. Also, docker-mux container hold packages related to maintaining and managing mux cable. It currently runs linkmgrd binary that monitor and switches the mux if needed. This PR also introduces mux-container and starts linkmgrd as startup when build is configured with INCLUDE_MUX=y Edit: linkmgrd PR will follow. signed-off-by: Tamer Ahmed <[email protected]> Related work items: sonic-net#2315, #3146150
During warm reboot, linkmgrd would go away and so heartbeats will be lost. This would result in standby link son peer ToR to pull the link active. This is undesirable since we would not create tunnel from the ToR that is being rebooted to the peer ToR. This PR implicitly lock the state of the mux if config is not set to auto. Also, orchagent does not initialize MUX to it hardware state, rather it initilizes MUX to Unknown state. linkmgrd will detect this situation and probe MUX state to correct orchagent state. There a fix for the case when state os switched MUX is delayed. The PR will poll the MUX for the new state. This is required to update the state ds and hence create/tear tunnel. signed-off-by: Tamer Ahmed <[email protected]>
Ading new packaging variable to mux docker signed-off-by: Tamer Ahmed <[email protected]>
This PR deletes local-to-buildimage linkmgrd and creates new submodule pointing to github repo of sonic-linkmgrd. signed-off-by: Tamer Ahmed <[email protected]>
[mux] Start Mux on Only Dual-ToR Platform mux docker depends on the presence of mux cable hardware and is supposed to run only Gemini ToRs. This PR change the mux feature config in order to enable mux docker based on device configuration. signed-off-by: Tamer Ahmed <[email protected]>
[mux.service]: Bind to sonic.target Signed-off-by: Lawrence Lee <[email protected]>
[mux] Update Service Install With SONiC Target Recent PR grouped all SONiC service into sonic.taget. The install section of mux.service was not update and this causes delays when using config reload as the service failed state is not being reset. signed-off-by: Tamer Ahmed <[email protected]>
zjswhhh
force-pushed
the
taahme/build-sonic-image-with-mux
branch
from
5be5994 to
0abeca2
Compare
yxieca
previously approved these changes
Sep 28, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request introduces 7 alerts when merging 61f1903b779a5aa04fc030d29ecb7d10007aff7f into df6361f - view on LGTM.com new alerts:
|
|
This pull request introduces 5 alerts when merging cea6590911e060a79affec9832aa98d7b59a1a40 into 552963a - view on LGTM.com new alerts:
|
theasianpianist
force-pushed
the
taahme/build-sonic-image-with-mux
branch
from
cea6590 to
7b4dbda
Compare
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]> [write_standby]: Cleanup and fix build Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
[bgp]: Switch mux to standby if BGP container exits Signed-off-by: Lawrence Lee <[email protected]>
[write_standby]: Ignore non-auto interfaces * In the event that `write_standby.py` is used to automatically switchover interfaces when linkmgrd or bgp crashes, ignore any interfaces that are not configured to auto-switch Signed-off-by: Lawrence Lee <[email protected]>
theasianpianist
force-pushed
the
taahme/build-sonic-image-with-mux
branch
from
7b4dbda to
1b9711c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Oct 14, 2021
liushilongbuaa
approved these changes
Oct 14, 2021
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
|
@yxieca Did you intend to remove 202012 label? |
Thanks! Fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Internal mux container is out of Beta and is now available on sonic-linkmgrd.
How I did it
Added submodule and pointer to tip of master branch of sonic-linkmgrd.
Also, added packages variable that is not in internal branch.
How to verify it
image produced with mux container and service
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)