Skip to content

[centec] support TM.MX board v682-48y8c_d #8747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LuiSzee
Copy link
Contributor

@LuiSzee LuiSzee commented Sep 14, 2021

Adding platform support for centec v682-48y8c_d.

Why I did it

Adding platform support for centec v682-48y8c_d.
This switch has 48 SFP+ (1G/10G/25G) ports, 8 QSFP28 (40G/100G) ports on CENTEC TsingMa.MX.
CPU used in v682-48y8c_d is Intel(R) Xeon(R) CPU D-1527.

How I did it

  1. Modify related code in platform and device directory.
  2. Upgrade sai to v1.8.
  3. fix bug for parallel compile centec platform modules.

How to verify it

Build centec amd64 sonic image, verify platform functions (port, sfp, led etc) on centec v682-48y8c_d board.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@LuiSzee LuiSzee requested a review from lguohan as a code owner September 14, 2021 06:16
@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2021

This pull request introduces 11 alerts when merging ceb62300e7d2a4daef996a12f793e98e48075df4 into db529af - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 1 for Testing equality to None
  • 1 for Module imports itself
  • 1 for Unreachable code
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong number of arguments in a class instantiation

	1. support tsingma mx board v682-48y8c_d
	2. fix bug for parallel compile centec platform module
@LuiSzee LuiSzee force-pushed the devpr_centec_master_20210913_v682 branch from ceb6230 to 8f3905c Compare September 14, 2021 06:54
@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2021

This pull request introduces 1 alert when merging 8f3905c into db529af - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a class instantiation

@LuiSzee
Copy link
Contributor Author

LuiSzee commented Sep 14, 2021

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guxianghong
Copy link
Contributor

Please help to review this PR, Thanks very much, @lguohan @sujinmkang

@sujinmkang sujinmkang requested a review from prgeor October 22, 2021 19:47
@sujinmkang
Copy link
Collaborator

Can you share the show platform command output?

@LuiSzee
Copy link
Contributor Author

LuiSzee commented Oct 25, 2021

Here is the show platform command output:
https://github.com/LuiSzee/tests/blob/main/centec/show_platform_v682_48y8c_d.txt

@sujinmkang sujinmkang merged commit 32ad744 into sonic-net:master Oct 26, 2021
@LuiSzee LuiSzee deleted the devpr_centec_master_20210913_v682 branch November 22, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants